Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/cronet.gypi

Issue 274183002: Make it possible to build cronet without icu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Oops...add back file Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/cronet_jni.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet.gypi
diff --git a/components/cronet.gypi b/components/cronet.gypi
index d749c8e0b889cb65d0cfb440dae15e87052ebc45..5832c6ebb48df8307d16e7b81e607143dc853544 100644
--- a/components/cronet.gypi
+++ b/components/cronet.gypi
@@ -89,7 +89,17 @@
'-landroid',
'-Wl,--gc-sections',
'-Wl,--exclude-libs,ALL'
- ]
+ ],
+ 'conditions': [
+ [ 'use_icu_alternatives_on_android == 1', {
+ 'dependencies!': [
+ '../base/base.gyp:base_i18n',
+ '../third_party/icu/icu.gyp:icui18n',
+ '../third_party/icu/icu.gyp:icuuc',
+ ]
+ },
+ ],
+ ],
},
{
'target_name': 'cronet',
« no previous file with comments | « no previous file | components/cronet/android/cronet_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698