Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chromeos/dbus/services/liveness_service_provider.h

Issue 2741803005: Split LivenessService out from LibCrosService. (Closed)
Patch Set: Add blank line above liveness_service_ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/services/liveness_service_provider.h
diff --git a/chromeos/dbus/services/liveness_service_provider.h b/chromeos/dbus/services/liveness_service_provider.h
index 75092a3d73d79a1e6b1126a7c4a1c4a03179c8c9..26dca2adda4e710a8935b37fdd882c4baaa744bf 100644
--- a/chromeos/dbus/services/liveness_service_provider.h
+++ b/chromeos/dbus/services/liveness_service_provider.h
@@ -26,9 +26,9 @@ namespace chromeos {
// messages. It can be tested with the following command:
//
// % dbus-send --system --type=method_call --print-reply
-// --dest=org.chromium.LibCrosService
-// /org/chromium/LibCrosService
-// org.chromium.LibCrosServiceInterface.CheckLiveness
+// --dest=org.chromium.LivenessService
+// /org/chromium/LivenessService
+// org.chromium.LivenessServiceInterface.CheckLiveness
//
// -> method return sender=:1.9 -> dest=:1.27 reply_serial=2
//
@@ -36,7 +36,9 @@ namespace chromeos {
class CHROMEOS_EXPORT LivenessServiceProvider
: public CrosDBusService::ServiceProviderInterface {
public:
- LivenessServiceProvider();
+ // TODO(teravest): Remove the service_interface argument once this is no
+ // longer used by LibCrosService.
+ explicit LivenessServiceProvider(const std::string& service_interface);
~LivenessServiceProvider() override;
// CrosDBusService::ServiceProviderInterface overrides:
@@ -53,6 +55,8 @@ class CHROMEOS_EXPORT LivenessServiceProvider
void CheckLiveness(dbus::MethodCall* method_call,
dbus::ExportedObject::ResponseSender response_sender);
+ std::string service_interface_;
+
// Keep this last so that all weak pointers will be invalidated at the
// beginning of destruction.
base::WeakPtrFactory<LivenessServiceProvider> weak_ptr_factory_;
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.cc ('k') | chromeos/dbus/services/liveness_service_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698