Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2741803004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
afakhry
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file( feedback, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=afakhry@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2741803004 Cr-Commit-Position: refs/heads/master@{#457127} Committed: https://chromium.googlesource.com/chromium/src/+/c6d234a7184e24e2def0900efaa4c1ba18069165

Patch Set 1 #

Patch Set 2 : add empty line #

Total comments: 4

Patch Set 3 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/chromeos/system_logs/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/feedback/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/feedback/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/task_manager/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/feedback/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 22:27:52 UTC) #2
afakhry
https://codereview.chromium.org/2741803004/diff/20001/chrome/browser/chromeos/resource_reporter/OWNERS File chrome/browser/chromeos/resource_reporter/OWNERS (right): https://codereview.chromium.org/2741803004/diff/20001/chrome/browser/chromeos/resource_reporter/OWNERS#newcode4 chrome/browser/chromeos/resource_reporter/OWNERS:4: # COMPONENT: Infra>Client>ChromeOS This is the wrong component. Currently ...
3 years, 9 months ago (2017-03-15 03:29:49 UTC) #3
ymzhang1
Thanks for the comments! https://codereview.chromium.org/2741803004/diff/20001/chrome/browser/chromeos/resource_reporter/OWNERS File chrome/browser/chromeos/resource_reporter/OWNERS (right): https://codereview.chromium.org/2741803004/diff/20001/chrome/browser/chromeos/resource_reporter/OWNERS#newcode4 chrome/browser/chromeos/resource_reporter/OWNERS:4: # COMPONENT: Infra>Client>ChromeOS On 2017/03/15 ...
3 years, 9 months ago (2017-03-15 17:09:36 UTC) #5
afakhry
lgtm
3 years, 9 months ago (2017-03-15 17:31:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741803004/60001
3 years, 9 months ago (2017-03-15 17:33:21 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 17:46:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c6d234a7184e24e2def0900efaa4...

Powered by Google App Engine
This is Rietveld 408576698