Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2741803002: Reland: Implement effect compositing for indirect reasons (Closed)

Created:
3 years, 9 months ago by chrishtr
Modified:
3 years, 9 months ago
Reviewers:
pdr., Xianzhu
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Improve performance of GeometryMapper cache. New version initializes m_cacheGeneration in GeometryMapperClipCache and GeometryMapperTransformCache constructors. Verified it fixes the msan layout test failures. 1. Store clips and transforms in vectors attached to the clip and transform nodes. This avoids all hash map lookups. Invalidation uses a global cache generation id (currently we don't support anything other than global invalidation of the GeometryMapper caches). 2. Return clips and transforms by reference, to avoid copying. and transforms relative to the same ancestor, so the vectors are short and hash lookups are reduced. BUG=692614 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2729243002 Cr-Commit-Position: refs/heads/master@{#455571} Committed: https://chromium.googlesource.com/chromium/src/+/ee72c4b5d2fd1e4882bddca66e0f89fe8784a7fc patch from issue 2729243002 at patchset 690001 (http://crrev.com/2729243002#ps690001) Review-Url: https://codereview.chromium.org/2741803002 Cr-Commit-Position: refs/heads/master@{#455850} Committed: https://chromium.googlesource.com/chromium/src/+/890521e5189ff65fb2c16f67c837cc09bcf503c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -113 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h View 3 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h View 2 chunks +2 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 9 chunks +35 lines, -49 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/GeometryMapperClipCache.h View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/GeometryMapperClipCache.cpp View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 4 chunks +27 lines, -23 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTransformCache.h View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTransformCache.cpp View 1 chunk +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h View 3 chunks +17 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
chrishtr
3 years, 9 months ago (2017-03-09 18:02:44 UTC) #3
Xianzhu
lgtm
3 years, 9 months ago (2017-03-09 18:06:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741803002/1
3 years, 9 months ago (2017-03-09 18:08:17 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 20:23:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/890521e5189ff65fb2c16f67c837...

Powered by Google App Engine
This is Rietveld 408576698