Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2741783007: Convert ENABLE_WAYLAND_SERVER to a build flag. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by Nico
Modified:
7 months, 1 week ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ENABLE_WAYLAND_SERVER to a build flag. This way, ENABLE_WAYLAND_SERVER isn't defined globally, but only where it's needed (chrome/common and deps). No intended behavior change. BUG=none Review-Url: https://codereview.chromium.org/2741783007 Cr-Commit-Position: refs/heads/master@{#456293} Committed: https://chromium.googlesource.com/chromium/src/+/a6fa3d313a9e5a445c2ed406bc87e0affaa3cc63

Patch Set 1 #

Patch Set 2 : errrrr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/ui.gni View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/features.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 16 (12 generated)
Nico
7 months, 2 weeks ago (2017-03-11 18:56:59 UTC) #4
reveman
lgtm
7 months, 1 week ago (2017-03-11 22:45:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741783007/20001
7 months, 1 week ago (2017-03-11 23:08:43 UTC) #13
commit-bot: I haz the power
7 months, 1 week ago (2017-03-11 23:13:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a6fa3d313a9e5a445c2ed406bc87...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa