Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2741783006: Don't confuse VS 2013 with VS 2017 (Closed)

Created:
3 years, 9 months ago by brucedawson
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't confuse VS 2013 with VS 2017 Building with VS 2017 using a packaged toolchain is not yet supported but if you try to do it you get a surprising result - the VS 2013 toolchain gets downloaded. This adds a 2013 check to avoid this, and also simplifies/corrects an existing 2017 check and comment. This lets us fail-fast if a user tries the VS 2017 depot-tools combination before it is supported. BUG=683729 Review-Url: https://codereview.chromium.org/2741783006 Cr-Commit-Position: refs/heads/master@{#456226} Committed: https://chromium.googlesource.com/chromium/src/+/fead74a8e3d55044bc89fe96500275a0b5e3f24c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M build/vs_toolchain.py View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
brucedawson
Minor improvement to avoid version switching confusion - PTAL.
3 years, 9 months ago (2017-03-10 23:12:56 UTC) #3
brucedawson
PTAL
3 years, 9 months ago (2017-03-10 23:40:31 UTC) #5
Lei Zhang
lgtm
3 years, 9 months ago (2017-03-10 23:46:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741783006/1
3 years, 9 months ago (2017-03-10 23:47:25 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:15:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fead74a8e3d55044bc89fe965002...

Powered by Google App Engine
This is Rietveld 408576698