[Cronet] Append version to libcronet library name.

components/cronet/android/BUILD.gn

Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index a6b7b5237b2fa6d15b257959f3ffdace019ea155..64c395c60ee18eb689ada02fc39cc2dccb021061 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -256,6 +256,7 @@ cronet_static_tmpl("cronet_static") {
 }
 
 shared_library("cronet") {
+  output_name = "cronet.$chrome_version_full"

[kapishnikov, 2017/03/09 19:29:40]

Should we use '_' instead of '.' as the separator?  I couldn't find any .so file
that uses "." as the separator except for separating the version parts.

[pauljensen, 2017/03/10 01:55:34]

I think '.' is commonly used for this sort of thing; most libs in /usr/lib use
'.' to separate version parts.  It also makes the BUILD.gn and Java parts of
this change much simpler to use '.'

$ cd /usr/lib
$ ls -1d *\.0* | wc -l
235
$ ls -1d *_0*
ls: cannot access *_0*: No such file or directory

   sources = [
     "cronet_jni.cc",
   ]
@@ -1286,10 +1287,10 @@ action("cronet_combine_proguard_flags") {
 
 copy("cronet_package_copy_native_lib") {
   sources = [
-    "$root_out_dir/libcronet.so",
+    "$root_out_dir/libcronet.$chrome_version_full.so",

[kapishnikov, 2017/03/09 19:29:40]

Since we use "libcronet.$chrome_version_full.so" in four places, maybe we should
introduce an intermediate variable, like cronet_shared_library_file_name =
libcronet.$chrome_version_full.so

[pauljensen, 2017/03/10 01:55:34]

Done, I also made a variable for the simple name.

   ]
   outputs = [
-    "$_package_dir/libs/${android_app_abi}/libcronet.so",
+    "$_package_dir/libs/${android_app_abi}/libcronet.$chrome_version_full.so",
   ]
   deps = [
     ":cronet",
@@ -1298,10 +1299,10 @@ copy("cronet_package_copy_native_lib") {
 
 copy("cronet_package_copy_native_lib_unstripped") {
   sources = [
-    "$root_out_dir/lib.unstripped/libcronet.so",
+    "$root_out_dir/lib.unstripped/libcronet.$chrome_version_full.so",
   ]
   outputs = [
-    "$_package_dir/symbols/${android_app_abi}/libcronet.so",
+    "$_package_dir/symbols/${android_app_abi}/libcronet.$chrome_version_full.so",
   ]
   deps = [
     ":cronet",