[Cronet] Append version to libcronet library name.

components/cronet/android/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/util/process_version.gni")
 import("//build/util/version.gni")
 import("//testing/test.gni")
@@ skipping 238 matching lines @@
       "//components/data_reduction_proxy/core/common",
     ]
   }
 
   if (!use_platform_icu_alternatives) {
     deps += [ "//base:i18n" ]
   }
 }
 
 shared_library("cronet") {
+  output_name = "cronet.$chrome_version_full"

[kapishnikov, 2017/03/09 19:29:40]

Should we use '_' instead of '.' as the separator?  I couldn't find any .so file
that uses "." as the separator except for separating the version parts.

[pauljensen, 2017/03/10 01:55:34]

I think '.' is commonly used for this sort of thing; most libs in /usr/lib use
'.' to separate version parts.  It also makes the BUILD.gn and Java parts of
this change much simpler to use '.'

$ cd /usr/lib
$ ls -1d *\.0* | wc -l
235
$ ls -1d *_0*
ls: cannot access *_0*: No such file or directory

   sources = [
     "cronet_jni.cc",
   ]
   deps = [
     ":cronet_static",
     "//base",
     "//net:net",
   ]
 }
 
@@ skipping 1010 matching lines @@
     rebase_path("$target_gen_dir/cronet_impl_native_proguard.cfg",
                 root_build_dir),
     rebase_path("//components/cronet/android/cronet_impl_native_proguard.cfg",
                 root_build_dir),
     rebase_path("//base/android/proguard/chromium_code.flags", root_build_dir),
   ]
 }
 
 copy("cronet_package_copy_native_lib") {
   sources = [
-    "$root_out_dir/libcronet.so",
+    "$root_out_dir/libcronet.$chrome_version_full.so",

[kapishnikov, 2017/03/09 19:29:40]

Since we use "libcronet.$chrome_version_full.so" in four places, maybe we should
introduce an intermediate variable, like cronet_shared_library_file_name =
libcronet.$chrome_version_full.so

[pauljensen, 2017/03/10 01:55:34]

Done, I also made a variable for the simple name.

   ]
   outputs = [
-    "$_package_dir/libs/${android_app_abi}/libcronet.so",
+    "$_package_dir/libs/${android_app_abi}/libcronet.$chrome_version_full.so",
   ]
   deps = [
     ":cronet",
   ]
 }
 
 copy("cronet_package_copy_native_lib_unstripped") {
   sources = [
-    "$root_out_dir/lib.unstripped/libcronet.so",
+    "$root_out_dir/lib.unstripped/libcronet.$chrome_version_full.so",
   ]
   outputs = [
-    "$_package_dir/symbols/${android_app_abi}/libcronet.so",
+    "$_package_dir/symbols/${android_app_abi}/libcronet.$chrome_version_full.so",
   ]
   deps = [
     ":cronet",
   ]
 }
 
 copy("cronet_package_copy_native_test_lib") {
   testonly = true
   sources = [
     "$root_out_dir/libcronet_tests.so",
@@ skipping 178 matching lines @@
     deps = [
       ":cronet_package_copy_native_test_lib",
       ":cronet_package_copy_native_test_lib_unstripped",
       ":cronet_package_copy_test_assets",
       ":cronet_package_copy_test_files",
       ":cronet_package_copy_test_support_apks",
       ":repackage_extracted_test_jars",
     ]
   }
 }