win: Collect a MemoryInfoListStream in fallback minidumps

win: Collect a MemoryInfoListStream in fallback minidumps

The MiniDumpWithFullMemoryInfo dump type tells MiniDumpWriteDump() to
include a MemoryInfoListStream, which produces a
MINIDUMP_MEMORY_INFO_LIST structure. This contains information about a
process' memory map.

Crashpad always includes this stream when writing minidumps for Windows
processes, but the fallback handler, which monitors the Crashpad
handler, uses MiniDumpWriteDump() instead of Crashpad’s minidump writer
implementation, and needs to be instructed to include this data.

Note that MiniDumpWithFullMemoryInfo is distinct from
MiniDumpWithFullMemory. The former just includes the memory map, while
the latter captures a full memory dump (large and undesirable).

Review-Url: https://codereview.chromium.org/2741773002
Cr-Commit-Position: refs/heads/master@{#455998}
Committed: https://chromium.googlesource.com/chromium/src/+/df6aab609a8002e151b9a7590bbcf80cd6146e9d

[Mark Mentovai, 2017-03-09 16:39:37]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:40:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-03-09 16:40:41]

mark@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:22:41]

Dry run: This issue passed the CQ dry run.

[Sigurður Ásgeirsson, 2017-03-09 17:33:50]

siggi@chromium.org changed reviewers:
+ siggi@chromium.org

[Sigurður Ásgeirsson, 2017-03-09 17:33:50]

lgtm - though I've yet to find this information useful when present. What do you
use it for?

[Mark Mentovai, 2017-03-09 17:41:30]

In bug 698471, I wanted to know more about the region we were landing in and
trying to execute. It’s often useful to know whether a page is mapped or not,
and what the protection flags say.

[Mark Mentovai, 2017-03-10 04:45:03]

The CQ bit was checked by mark@chromium.org

[commit-bot: I haz the power, 2017-03-10 04:45:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 04:49:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489121103310570, "parent_rev":
"09aef2278437c8832d1dda60c8fa4641418f6e19", "commit_rev":
"df6aab609a8002e151b9a7590bbcf80cd6146e9d"}

[commit-bot: I haz the power, 2017-03-10 04:50:07]

Description was changed from

==========
win: Collect a MemoryInfoListStream in fallback minidumps

The MiniDumpWithFullMemoryInfo dump type tells MiniDumpWriteDump() to
include a MemoryInfoListStream, which produces a
MINIDUMP_MEMORY_INFO_LIST structure. This contains information about a
process' memory map.

Crashpad always includes this stream when writing minidumps for Windows
processes, but the fallback handler, which monitors the Crashpad
handler, uses MiniDumpWriteDump() instead of Crashpad’s minidump writer
implementation, and needs to be instructed to include this data.

Note that MiniDumpWithFullMemoryInfo is distinct from
MiniDumpWithFullMemory. The former just includes the memory map, while
the latter captures a full memory dump (large and undesirable).
==========

to

==========
win: Collect a MemoryInfoListStream in fallback minidumps

The MiniDumpWithFullMemoryInfo dump type tells MiniDumpWriteDump() to
include a MemoryInfoListStream, which produces a
MINIDUMP_MEMORY_INFO_LIST structure. This contains information about a
process' memory map.

Crashpad always includes this stream when writing minidumps for Windows
processes, but the fallback handler, which monitors the Crashpad
handler, uses MiniDumpWriteDump() instead of Crashpad’s minidump writer
implementation, and needs to be instructed to include this data.

Note that MiniDumpWithFullMemoryInfo is distinct from
MiniDumpWithFullMemory. The former just includes the memory map, while
the latter captures a full memory dump (large and undesirable).

Review-Url: https://codereview.chromium.org/2741773002
Cr-Commit-Position: refs/heads/master@{#455998}
Committed:
https://chromium.googlesource.com/chromium/src/+/df6aab609a8002e151b9a7590bbc...
==========

[commit-bot: I haz the power, 2017-03-10 04:50:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df6aab609a8002e151b9a7590bbc...