Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 7855f75b386a3a9413c47c0a095adc3d23b42709..c16142af1f8bc200da1251f1ec6254ebcedff45e 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -422,11 +422,11 @@ TEST(HeapSnapshotConsString) {
v8::HandleScope scope(isolate);
v8::Local<v8::ObjectTemplate> global_template =
v8::ObjectTemplate::New(isolate);
- global_template->SetInternalFieldCount(1);
+ global_template->SetEmbedderFieldCount(1);
LocalContext env(NULL, global_template);
v8::Local<v8::Object> global_proxy = env->Global();
v8::Local<v8::Object> global = global_proxy->GetPrototype().As<v8::Object>();
- CHECK_EQ(1, global->InternalFieldCount());
+ CHECK_EQ(1, global->EmbedderFieldCount());
i::Factory* factory = CcTest::i_isolate()->factory();
i::Handle<i::String> first = factory->NewStringFromStaticChars("0123456789");
@@ -434,7 +434,7 @@ TEST(HeapSnapshotConsString) {
i::Handle<i::String> cons_string =
factory->NewConsString(first, second).ToHandleChecked();
- global->SetInternalField(0, v8::ToApiHandle<v8::String>(cons_string));
+ global->SetEmbedderField(0, v8::ToApiHandle<v8::String>(cons_string));
v8::HeapProfiler* heap_profiler = isolate->GetHeapProfiler();
const v8::HeapSnapshot* snapshot = heap_profiler->TakeHeapSnapshot();
@@ -653,14 +653,14 @@ TEST(HeapSnapshotInternalReferences) {
v8::HandleScope scope(isolate);
v8::Local<v8::ObjectTemplate> global_template =
v8::ObjectTemplate::New(isolate);
- global_template->SetInternalFieldCount(2);
+ global_template->SetEmbedderFieldCount(2);
LocalContext env(NULL, global_template);
v8::Local<v8::Object> global_proxy = env->Global();
v8::Local<v8::Object> global = global_proxy->GetPrototype().As<v8::Object>();
- CHECK_EQ(2, global->InternalFieldCount());
+ CHECK_EQ(2, global->EmbedderFieldCount());
v8::Local<v8::Object> obj = v8::Object::New(isolate);
- global->SetInternalField(0, v8_num(17));
- global->SetInternalField(1, obj);
+ global->SetEmbedderField(0, v8_num(17));
+ global->SetEmbedderField(1, obj);
v8::HeapProfiler* heap_profiler = isolate->GetHeapProfiler();
const v8::HeapSnapshot* snapshot = heap_profiler->TakeHeapSnapshot();
CHECK(ValidateSnapshot(snapshot));

Powered by Google App Engine
This is Rietveld 408576698