Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: src/runtime/runtime-typedarray.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-typedarray.cc
diff --git a/src/runtime/runtime-typedarray.cc b/src/runtime/runtime-typedarray.cc
index 1ea42109b4988f6dabee20fbd37dac2a24c65fc9..356f03b21af30b3b0ba9d6f2b9d6a9625adbaffd 100644
--- a/src/runtime/runtime-typedarray.cc
+++ b/src/runtime/runtime-typedarray.cc
@@ -106,10 +106,10 @@ RUNTIME_FUNCTION(Runtime_TypedArrayInitialize) {
// All checks are done, now we can modify objects.
- DCHECK_EQ(v8::ArrayBufferView::kInternalFieldCount,
- holder->GetInternalFieldCount());
- for (int i = 0; i < v8::ArrayBufferView::kInternalFieldCount; i++) {
- holder->SetInternalField(i, Smi::kZero);
+ DCHECK_EQ(v8::ArrayBufferView::kEmbedderFieldCount,
+ holder->GetEmbedderFieldCount());
+ for (int i = 0; i < v8::ArrayBufferView::kEmbedderFieldCount; i++) {
+ holder->SetEmbedderField(i, Smi::kZero);
}
Handle<Object> length_obj = isolate->factory()->NewNumberFromSize(length);
holder->set_length(*length_obj);
@@ -179,10 +179,10 @@ RUNTIME_FUNCTION(Runtime_TypedArrayInitializeFromArrayLike) {
}
size_t byte_length = length * element_size;
- DCHECK_EQ(v8::ArrayBufferView::kInternalFieldCount,
- holder->GetInternalFieldCount());
- for (int i = 0; i < v8::ArrayBufferView::kInternalFieldCount; i++) {
- holder->SetInternalField(i, Smi::kZero);
+ DCHECK_EQ(v8::ArrayBufferView::kEmbedderFieldCount,
+ holder->GetEmbedderFieldCount());
+ for (int i = 0; i < v8::ArrayBufferView::kEmbedderFieldCount; i++) {
+ holder->SetEmbedderField(i, Smi::kZero);
}
// NOTE: not initializing backing store.

Powered by Google App Engine
This is Rietveld 408576698