Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: src/i18n.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/i18n.cc
diff --git a/src/i18n.cc b/src/i18n.cc
index 7c22871ff5e440f771659d44a0db013b34ec2105..6860c470dd201c0ee89713a8f5300a4c7fdc63d8 100644
--- a/src/i18n.cc
+++ b/src/i18n.cc
@@ -741,11 +741,11 @@ icu::SimpleDateFormat* DateFormat::InitializeDateTimeFormat(
icu::SimpleDateFormat* DateFormat::UnpackDateFormat(
Isolate* isolate,
Handle<JSObject> obj) {
- return reinterpret_cast<icu::SimpleDateFormat*>(obj->GetInternalField(0));
+ return reinterpret_cast<icu::SimpleDateFormat*>(obj->GetEmbedderField(0));
}
void DateFormat::DeleteDateFormat(const v8::WeakCallbackInfo<void>& data) {
- delete reinterpret_cast<icu::SimpleDateFormat*>(data.GetInternalField(0));
+ delete reinterpret_cast<icu::SimpleDateFormat*>(data.GetEmbedderField(0));
GlobalHandles::Destroy(reinterpret_cast<Object**>(data.GetParameter()));
}
@@ -796,11 +796,11 @@ icu::DecimalFormat* NumberFormat::InitializeNumberFormat(
icu::DecimalFormat* NumberFormat::UnpackNumberFormat(
Isolate* isolate,
Handle<JSObject> obj) {
- return reinterpret_cast<icu::DecimalFormat*>(obj->GetInternalField(0));
+ return reinterpret_cast<icu::DecimalFormat*>(obj->GetEmbedderField(0));
}
void NumberFormat::DeleteNumberFormat(const v8::WeakCallbackInfo<void>& data) {
- delete reinterpret_cast<icu::DecimalFormat*>(data.GetInternalField(0));
+ delete reinterpret_cast<icu::DecimalFormat*>(data.GetEmbedderField(0));
GlobalHandles::Destroy(reinterpret_cast<Object**>(data.GetParameter()));
}
@@ -848,11 +848,11 @@ icu::Collator* Collator::InitializeCollator(
icu::Collator* Collator::UnpackCollator(Isolate* isolate,
Handle<JSObject> obj) {
- return reinterpret_cast<icu::Collator*>(obj->GetInternalField(0));
+ return reinterpret_cast<icu::Collator*>(obj->GetEmbedderField(0));
}
void Collator::DeleteCollator(const v8::WeakCallbackInfo<void>& data) {
- delete reinterpret_cast<icu::Collator*>(data.GetInternalField(0));
+ delete reinterpret_cast<icu::Collator*>(data.GetEmbedderField(0));
GlobalHandles::Destroy(reinterpret_cast<Object**>(data.GetParameter()));
}
@@ -899,13 +899,13 @@ icu::BreakIterator* V8BreakIterator::InitializeBreakIterator(
icu::BreakIterator* V8BreakIterator::UnpackBreakIterator(Isolate* isolate,
Handle<JSObject> obj) {
- return reinterpret_cast<icu::BreakIterator*>(obj->GetInternalField(0));
+ return reinterpret_cast<icu::BreakIterator*>(obj->GetEmbedderField(0));
}
void V8BreakIterator::DeleteBreakIterator(
const v8::WeakCallbackInfo<void>& data) {
- delete reinterpret_cast<icu::BreakIterator*>(data.GetInternalField(0));
- delete reinterpret_cast<icu::UnicodeString*>(data.GetInternalField(1));
+ delete reinterpret_cast<icu::BreakIterator*>(data.GetEmbedderField(0));
+ delete reinterpret_cast<icu::UnicodeString*>(data.GetEmbedderField(1));
GlobalHandles::Destroy(reinterpret_cast<Object**>(data.GetParameter()));
}
« include/v8-experimental.h ('K') | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698