Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: src/fast-accessor-assembler.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/fast-accessor-assembler.cc
diff --git a/src/fast-accessor-assembler.cc b/src/fast-accessor-assembler.cc
index 6e7b49ea0b2508f2af3af5ceee52e170ec1d0824..016b96579c8b3f6bb738827de669b87fc23d5a7a 100644
--- a/src/fast-accessor-assembler.cc
+++ b/src/fast-accessor-assembler.cc
@@ -9,7 +9,7 @@
#include "src/code-stubs.h" // For CallApiCallbackStub.
#include "src/handles-inl.h"
#include "src/objects-inl.h"
-#include "src/objects.h" // For FAA::LoadInternalField impl.
+#include "src/objects.h" // For FAA::LoadEmbedderField impl.
namespace v8 {
namespace internal {
@@ -42,7 +42,7 @@ FastAccessorAssembler::ValueId FastAccessorAssembler::GetReceiver() {
return FromRaw(assembler_->Parameter(0));
}
-FastAccessorAssembler::ValueId FastAccessorAssembler::LoadInternalField(
+FastAccessorAssembler::ValueId FastAccessorAssembler::LoadEmbedderField(
ValueId value_id, int field_no) {
CHECK_EQ(kBuilding, state_);
@@ -53,10 +53,10 @@ FastAccessorAssembler::ValueId FastAccessorAssembler::LoadInternalField(
CheckIsJSObjectOrJump(value_id, is_not_jsobject);
- Node* internal_field = assembler_->LoadObjectField(
+ Node* embedder_field = assembler_->LoadObjectField(
FromId(value_id), JSObject::kHeaderSize + kPointerSize * field_no);
- result.Bind(internal_field);
+ result.Bind(embedder_field);
assembler_->Goto(&merge);
// Return null, mimicking the C++ counterpart.
@@ -70,7 +70,7 @@ FastAccessorAssembler::ValueId FastAccessorAssembler::LoadInternalField(
}
FastAccessorAssembler::ValueId
-FastAccessorAssembler::LoadInternalFieldUnchecked(ValueId value_id,
+FastAccessorAssembler::LoadEmbedderFieldUnchecked(ValueId value_id,
int field_no) {
CHECK_EQ(kBuilding, state_);

Powered by Google App Engine
This is Rietveld 408576698