Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: src/factory.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index e19b331491a7a32735c3dae8e3ca42f21bbebfed..12c146885a65f418c7f35b74e93652c4af9e5ca8 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1640,7 +1640,7 @@ Handle<ModuleInfo> Factory::NewModuleInfo() {
Handle<JSObject> Factory::NewExternal(void* value) {
Handle<Foreign> foreign = NewForeign(static_cast<Address>(value));
Handle<JSObject> external = NewJSObjectFromMap(external_map());
- external->SetInternalField(0, *foreign);
+ external->SetEmbedderField(0, *foreign);
return external;
}
@@ -2123,10 +2123,10 @@ void SetupArrayBufferView(i::Isolate* isolate,
DCHECK(byte_offset + byte_length <=
static_cast<size_t>(buffer->byte_length()->Number()));
- DCHECK_EQ(obj->GetInternalFieldCount(),
- v8::ArrayBufferView::kInternalFieldCount);
- for (int i = 0; i < v8::ArrayBufferView::kInternalFieldCount; i++) {
- obj->SetInternalField(i, Smi::kZero);
+ DCHECK_EQ(obj->GetEmbedderFieldCount(),
+ v8::ArrayBufferView::kEmbedderFieldCount);
+ for (int i = 0; i < v8::ArrayBufferView::kEmbedderFieldCount; i++) {
+ obj->SetEmbedderField(i, Smi::kZero);
}
obj->set_buffer(*buffer);
@@ -2198,10 +2198,10 @@ Handle<JSTypedArray> Factory::NewJSTypedArray(ElementsKind elements_kind,
size_t number_of_elements,
PretenureFlag pretenure) {
Handle<JSTypedArray> obj = NewJSTypedArray(elements_kind, pretenure);
- DCHECK_EQ(obj->GetInternalFieldCount(),
- v8::ArrayBufferView::kInternalFieldCount);
- for (int i = 0; i < v8::ArrayBufferView::kInternalFieldCount; i++) {
- obj->SetInternalField(i, Smi::kZero);
+ DCHECK_EQ(obj->GetEmbedderFieldCount(),
+ v8::ArrayBufferView::kEmbedderFieldCount);
+ for (int i = 0; i < v8::ArrayBufferView::kEmbedderFieldCount; i++) {
+ obj->SetEmbedderField(i, Smi::kZero);
}
size_t element_size = GetFixedTypedArraysElementSize(elements_kind);

Powered by Google App Engine
This is Rietveld 408576698