Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: src/api-natives.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/api-natives.cc
diff --git a/src/api-natives.cc b/src/api-natives.cc
index 3b250c1567c5de5c25f24cda56a18f4604441c9d..d055e5320f23865f3db0b04eb7c31161df10bd53 100644
--- a/src/api-natives.cc
+++ b/src/api-natives.cc
@@ -543,7 +543,7 @@ MaybeHandle<JSObject> ApiNatives::InstantiateRemoteObject(
initial_map, shared, isolate->factory()->undefined_value());
Handle<Map> object_map = isolate->factory()->NewMap(
JS_SPECIAL_API_OBJECT_TYPE,
- JSObject::kHeaderSize + data->internal_field_count() * kPointerSize,
+ JSObject::kHeaderSize + data->embedder_field_count() * kPointerSize,
FAST_HOLEY_SMI_ELEMENTS);
JSFunction::SetInitialMap(object_function, object_map,
isolate->factory()->null_value());
@@ -639,18 +639,18 @@ Handle<JSFunction> ApiNatives::CreateApiFunction(
DONT_ENUM);
}
- int internal_field_count = 0;
+ int embedder_field_count = 0;
bool immutable_proto = false;
if (!obj->instance_template()->IsUndefined(isolate)) {
Handle<ObjectTemplateInfo> instance_template = Handle<ObjectTemplateInfo>(
ObjectTemplateInfo::cast(obj->instance_template()));
- internal_field_count = instance_template->internal_field_count();
+ embedder_field_count = instance_template->embedder_field_count();
immutable_proto = instance_template->immutable_proto();
}
// TODO(svenpanne) Kill ApiInstanceType and refactor things by generalizing
// JSObject::GetHeaderSize.
- int instance_size = kPointerSize * internal_field_count;
+ int instance_size = kPointerSize * embedder_field_count;
InstanceType type;
switch (instance_type) {
case JavaScriptObjectType:
« include/v8-experimental.h ('K') | « src/api-experimental.cc ('k') | src/bootstrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698