Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2741673003: cros: Dump login/lock/oobe JS error stack traces to logs. (Closed)

Created:
3 years, 9 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Dump login/lock/oobe JS error stack traces to logs. BUG=699798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2741673003 Cr-Commit-Position: refs/heads/master@{#455889} Committed: https://chromium.googlesource.com/chromium/src/+/2dda79a0be4d6c98602315f68301531ad34ce613

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/login_shared.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
jdufault
achuith@ PTAL
3 years, 9 months ago (2017-03-09 22:34:28 UTC) #15
achuithb
lgtm, best of luck
3 years, 9 months ago (2017-03-09 22:38:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741673003/20001
3 years, 9 months ago (2017-03-09 22:41:57 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 22:47:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2dda79a0be4d6c98602315f68301...

Powered by Google App Engine
This is Rietveld 408576698