Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: src/inspector/js_protocol.json

Issue 2741653003: [inspector] do not translate offset to line/column for coverage. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-profiler-agent-impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/js_protocol.json
diff --git a/src/inspector/js_protocol.json b/src/inspector/js_protocol.json
index 4237c45453b0400fa911daf22fbe5860296a557a..5cc26946288ffb2ad8e6cf2f88e1b1f500aac667 100644
--- a/src/inspector/js_protocol.json
+++ b/src/inspector/js_protocol.json
@@ -848,10 +848,6 @@
"type": "object",
"description": "Coverage data for a source range.",
"properties": [
- { "name": "startLineNumber", "type": "integer", "description": "JavaScript script line number (0-based) for the range start." },
pfeldman 2017/03/09 21:18:53 protocol lgtm. we can't change front-end though be
- { "name": "startColumnNumber", "type": "integer", "description": "JavaScript script column number (0-based) for the range start." },
- { "name": "endLineNumber", "type": "integer", "description": "JavaScript script line number (0-based) for the range end." },
- { "name": "endColumnNumber", "type": "integer", "description": "JavaScript script column number (0-based) for the range end." },
{ "name": "startOffset", "type": "integer", "description": "JavaScript script source offset for the range start." },
{ "name": "endOffset", "type": "integer", "description": "JavaScript script source offset for the range end." },
{ "name": "count", "type": "integer", "description": "Collected execution count of the source range." }
« no previous file with comments | « no previous file | src/inspector/v8-profiler-agent-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698