Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2741643004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (metrics, zlib, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=asvitkine@chromium.org Review-Url: https://codereview.chromium.org/2741643004 Cr-Commit-Position: refs/heads/master@{#455880} Committed: https://chromium.googlesource.com/chromium/src/+/8241f12c66198708d14bc08088cb00758def4762

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 2

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/android/metrics/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/variations/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mt19937ar/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/variations/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/text/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-09 21:39:51 UTC) #3
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2741643004/diff/40001/ui/base/text/OWNERS File ui/base/text/OWNERS (right): https://codereview.chromium.org/2741643004/diff/40001/ui/base/text/OWNERS#newcode3 ui/base/text/OWNERS:3: # COMPONENT: UI>Input>Text I think this should be ...
3 years, 9 months ago (2017-03-09 21:47:09 UTC) #4
ymzhang1
Thanks for the quick reply! https://codereview.chromium.org/2741643004/diff/40001/ui/base/text/OWNERS File ui/base/text/OWNERS (right): https://codereview.chromium.org/2741643004/diff/40001/ui/base/text/OWNERS#newcode3 ui/base/text/OWNERS:3: # COMPONENT: UI>Input>Text On ...
3 years, 9 months ago (2017-03-09 21:50:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741643004/60001
3 years, 9 months ago (2017-03-09 21:50:47 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 22:20:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8241f12c66198708d14bc08088cb...

Powered by Google App Engine
This is Rietveld 408576698