Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2741613004: Handle TEXTURE_SWIZZLE_* in gpu::gles2::Texture::SetParameterf (Closed)

Created:
3 years, 9 months ago by Kai Ninomiya
Modified:
3 years, 9 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle TEXTURE_SWIZZLE_* in gpu::gles2::Texture::SetParameterf BUG=699492 R=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2741613004 Cr-Commit-Position: refs/heads/master@{#455907} Committed: https://chromium.googlesource.com/chromium/src/+/cf1b262051defdc479dbb966eff4f99d394b8c19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Kai Ninomiya
zmo, PTAL
3 years, 9 months ago (2017-03-09 21:54:30 UTC) #2
Zhenyao Mo
lgtm
3 years, 9 months ago (2017-03-09 21:56:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741613004/1
3 years, 9 months ago (2017-03-09 22:58:49 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 23:53:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf1b262051defdc479dbb966eff4...

Powered by Google App Engine
This is Rietveld 408576698