Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2741613002:
Add case to verify the coexistence of primary Surface and fallback Surface (Closed)
DescriptionAdd case to verify the coexistence of primary Surface and fallback Surface
This test verifies that in the presence of both primary Surface and fallback
Surface, the fallback will not be used.
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2741613002
Cr-Commit-Position: refs/heads/master@{#455679}
Committed: https://chromium.googlesource.com/chromium/src/+/c557499d084ee51e7d13676cbf0951c92e3b5688
Patch Set 1 #Patch Set 2 : Sort case in alpha order #
Total comments: 1
Patch Set 3 : Refine comments #Messages
Total messages: 19 (14 generated)
Description was changed from ========== Add case to verify the coexist of both primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None ========== to ========== Add case to verify the coexist of both primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by xing.xu@intel.com to run a CQ dry run
Description was changed from ========== Add case to verify the coexist of both primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Add case to verify the coexist of both primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
xing.xu@intel.com changed reviewers: + jbauman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by xing.xu@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
Description was changed from ========== Add case to verify the coexist of both primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Add case to verify the coexistence of primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
lgtm, one nit. https://codereview.chromium.org/2741613002/diff/20001/cc/surfaces/surface_agg... File cc/surfaces/surface_aggregator_unittest.cc (right): https://codereview.chromium.org/2741613002/diff/20001/cc/surfaces/surface_agg... cc/surfaces/surface_aggregator_unittest.cc:472: // SolidColorDrawQuad. Fix this comment to match the test.
On 2017/03/09 03:01:18, jbauman wrote: > lgtm, one nit. > > https://codereview.chromium.org/2741613002/diff/20001/cc/surfaces/surface_agg... > File cc/surfaces/surface_aggregator_unittest.cc (right): > > https://codereview.chromium.org/2741613002/diff/20001/cc/surfaces/surface_agg... > cc/surfaces/surface_aggregator_unittest.cc:472: // SolidColorDrawQuad. > Fix this comment to match the test. Thanks, done!
The CQ bit was checked by xing.xu@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org Link to the patchset: https://codereview.chromium.org/2741613002/#ps40001 (title: "Refine comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489038522039090,
"parent_rev": "71f05187c1c575f42a2a37c197ffd3b85945bfd8", "commit_rev":
"c557499d084ee51e7d13676cbf0951c92e3b5688"}
Message was sent while issue was closed.
Description was changed from ========== Add case to verify the coexistence of primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Add case to verify the coexistence of primary Surface and fallback Surface This test verifies that in the presence of both primary Surface and fallback Surface, the fallback will not be used. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2741613002 Cr-Commit-Position: refs/heads/master@{#455679} Committed: https://chromium.googlesource.com/chromium/src/+/c557499d084ee51e7d13676cbf09... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/c557499d084ee51e7d13676cbf09... |
