Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2741573003: Allow C++11 in unittests. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow C++11 in unittests. BUG=v8:6072 Review-Url: https://codereview.chromium.org/2741573003 Cr-Commit-Position: refs/heads/master@{#43712} Committed: https://chromium.googlesource.com/v8/v8/+/62b0fa2ee92ebc3695f4b1f33dfa3eec48ffb2f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M test/cctest/test-utils.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Yang
3 years, 9 months ago (2017-03-10 06:30:17 UTC) #6
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-10 06:31:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741573003/1
3 years, 9 months ago (2017-03-10 06:32:56 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 06:35:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/62b0fa2ee92ebc3695f4b1f33dfa3eec48f...

Powered by Google App Engine
This is Rietveld 408576698