Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp

Issue 2741563002: ResourceLoadTiming should not be assumed to be available in ResourceTiming. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp
index 3353a97ef0b3410e2f53f5045d7ba8618890336b..3b4eb069a43bfc7f24e1dee2611ce50a9e2dbc66 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp
@@ -136,10 +136,10 @@ DOMHighResTimeStamp PerformanceResourceTiming::redirectEnd() const {
}
DOMHighResTimeStamp PerformanceResourceTiming::fetchStart() const {
+ if (!m_timing)
+ return PerformanceEntry::startTime();
+
if (m_lastRedirectEndTime) {
- // FIXME: ASSERT(m_timing) should be in constructor once timeticks of
- // AppCache is exposed from chrome network stack, crbug/251100
panicker 2017/03/08 23:16:51 This assumption was apparently fine in Jun 2013 (i
- ASSERT(m_timing);
return PerformanceBase::monotonicTimeToDOMHighResTimeStamp(
m_timeOrigin, m_timing->requestTime());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698