Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp

Issue 2741563002: ResourceLoadTiming should not be assumed to be available in ResourceTiming. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 129
130 DOMHighResTimeStamp PerformanceResourceTiming::redirectEnd() const { 130 DOMHighResTimeStamp PerformanceResourceTiming::redirectEnd() const {
131 if (!m_lastRedirectEndTime || !m_allowRedirectDetails) 131 if (!m_lastRedirectEndTime || !m_allowRedirectDetails)
132 return 0.0; 132 return 0.0;
133 133
134 return PerformanceBase::monotonicTimeToDOMHighResTimeStamp( 134 return PerformanceBase::monotonicTimeToDOMHighResTimeStamp(
135 m_timeOrigin, m_lastRedirectEndTime); 135 m_timeOrigin, m_lastRedirectEndTime);
136 } 136 }
137 137
138 DOMHighResTimeStamp PerformanceResourceTiming::fetchStart() const { 138 DOMHighResTimeStamp PerformanceResourceTiming::fetchStart() const {
139 if (!m_timing)
140 return PerformanceEntry::startTime();
141
139 if (m_lastRedirectEndTime) { 142 if (m_lastRedirectEndTime) {
140 // FIXME: ASSERT(m_timing) should be in constructor once timeticks of
141 // AppCache is exposed from chrome network stack, crbug/251100
panicker 2017/03/08 23:16:51 This assumption was apparently fine in Jun 2013 (i
142 ASSERT(m_timing);
143 return PerformanceBase::monotonicTimeToDOMHighResTimeStamp( 143 return PerformanceBase::monotonicTimeToDOMHighResTimeStamp(
144 m_timeOrigin, m_timing->requestTime()); 144 m_timeOrigin, m_timing->requestTime());
145 } 145 }
146 146
147 if (DOMHighResTimeStamp workerReadyTime = workerReady()) 147 if (DOMHighResTimeStamp workerReadyTime = workerReady())
148 return workerReadyTime; 148 return workerReadyTime;
149 149
150 return PerformanceEntry::startTime(); 150 return PerformanceEntry::startTime();
151 } 151 }
152 152
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 builder.addNumber("secureConnectionStart", secureConnectionStart()); 280 builder.addNumber("secureConnectionStart", secureConnectionStart());
281 builder.addNumber("requestStart", requestStart()); 281 builder.addNumber("requestStart", requestStart());
282 builder.addNumber("responseStart", responseStart()); 282 builder.addNumber("responseStart", responseStart());
283 builder.addNumber("responseEnd", responseEnd()); 283 builder.addNumber("responseEnd", responseEnd());
284 builder.addNumber("transferSize", transferSize()); 284 builder.addNumber("transferSize", transferSize());
285 builder.addNumber("encodedBodySize", encodedBodySize()); 285 builder.addNumber("encodedBodySize", encodedBodySize());
286 builder.addNumber("decodedBodySize", decodedBodySize()); 286 builder.addNumber("decodedBodySize", decodedBodySize());
287 } 287 }
288 288
289 } // namespace blink 289 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698