Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 2741543002: Copy HRTF files to webaudio/resources/hrtf (Closed)

Created:
3 years, 9 months ago by Raymond Toy
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy HRTF files to webaudio/resources/hrtf Don't reference the files in Source/platform/audio/resources from the tests. Copy them to webaudio/resources/hrtf. And add a README to indicate where these files came from. The README in platform/audio/resources already references this directory, so we're all set. Also removed the files from BUILD.gn, reverting the previous change. BUG=693838 , TEST=hrtf-database.html Review-Url: https://codereview.chromium.org/2741543002 Cr-Commit-Position: refs/heads/master@{#455853} Committed: https://chromium.googlesource.com/chromium/src/+/45c331005b44ee0528b6aaaf8b0fbc8ab249b567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Panner/hrtf-database.html View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/resources/hrtf/Composite.flac View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/resources/hrtf/Composite.wav View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/resources/hrtf/README View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL. I've copied the files to the resources/hrtf directory so that we don't refer to ...
3 years, 9 months ago (2017-03-08 22:55:47 UTC) #2
Dirk Pranke
Yes, this should solve the problem. LGTM, thanks :).
3 years, 9 months ago (2017-03-09 02:25:18 UTC) #3
hongchan
lgtm
3 years, 9 months ago (2017-03-09 18:01:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741543002/1
3 years, 9 months ago (2017-03-09 18:13:03 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 20:34:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45c331005b44ee0528b6aaaf8b0f...

Powered by Google App Engine
This is Rietveld 408576698