Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2741523002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, ozone-reviews_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (ozone, gesture, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=rjkroege@chromium.org Review-Url: https://codereview.chromium.org/2741523002 Cr-Commit-Position: refs/heads/master@{#455795} Committed: https://chromium.googlesource.com/chromium/src/+/b96c187039530ba593e4f07e5aa5714b556f4fd8

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 20

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M content/renderer/mus/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/demo/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/display/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/gpu/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/surfaces/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/gestures/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/cursor/ozone/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/gestures/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ymzhang1
ello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-08 21:07:53 UTC) #2
rjkroege
more like that maybe? https://codereview.chromium.org/2741523002/diff/20001/services/ui/demo/OWNERS File services/ui/demo/OWNERS (right): https://codereview.chromium.org/2741523002/diff/20001/services/ui/demo/OWNERS#newcode4 services/ui/demo/OWNERS:4: # COMPONENT: Platform>Apps>Demo should be ...
3 years, 9 months ago (2017-03-08 22:29:52 UTC) #3
ymzhang1
Thanks for the comments! P.S.: New component could also be created if needed. https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request https://codereview.chromium.org/2741523002/diff/20001/services/ui/demo/OWNERS ...
3 years, 9 months ago (2017-03-08 23:05:26 UTC) #5
rjkroege
lgtm
3 years, 9 months ago (2017-03-09 18:04:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741523002/60001
3 years, 9 months ago (2017-03-09 18:07:01 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:19:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b96c187039530ba593e4f07e5aa5...

Powered by Google App Engine
This is Rietveld 408576698