Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2741513002: [Merge M-57] Add a warning for the deprecation of content-initiated data URL navigations (Closed)

Created:
3 years, 9 months ago by meacer
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M-57] Add a warning for the deprecation of content-initiated data URL navigations This CL adds a console warning when a page navigates the top level frame to a data URL. The browser tests are added to WebContentsImpl tests to be consistent with the view-source URL tests. This CL also updates most of the layout tests to avoid loading data URLs at the top level. The only exceptions are xss-DENIED-* tests which will be updated when the actual blocking happens. BUG=594215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2694903007 Cr-Commit-Position: refs/heads/master@{#455226} (cherry picked from commit b29954e8ac243142eaedbcc3c6e54d480373ee38) Review-Url: https://codereview.chromium.org/2741513002 . Cr-Commit-Position: refs/branch-heads/2987@{#801} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/28845e05d13bf0da3e4d8b2f483c9f537f6562dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -121 lines) Patch
M content/browser/frame_host/navigation_handle_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 2 chunks +85 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Geolocation/clear-watch-invalid-id-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Geolocation/notimer-after-unload-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/mozilla-focus-blur.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/mozilla-focus-blur-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/resources/file-origin-window-open-frame.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Window/resources/file-origin-window-open-popup.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Window/resources/mozilla-focus-blur-popup-blur.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Window/resources/mozilla-focus-blur-popup-opener-focus.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/id-attribute-shared.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/id-attribute-shared-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/move-event-handler-between-framehosts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onunload.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onunload-clears-onbeforeunload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onunload-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onunload-not-on-body.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onunload-not-on-body-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onunload-window-property.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/onunload-window-property-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/page-visibility-unload.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pageshow-pagehide-on-back-uncached.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-untrusted-mouse-click.html View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/resources/move-event-handler-between-framehosts-popup.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/resources/onunload-clears-onbeforeunload-success.html View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/resources/onunload-single-alert-success.html View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/resources/page-visibility-alert-success.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/null-origin-string.html View 3 chunks +15 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/files/resources/notify-no-crash.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/button-state-restore.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/multiple-form-submission-protection-mouse.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/radio/state-restore-radio-group.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/resources/multiple-form-submission-protection-post-target.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/saved-state-adoptNode-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select/select-state-restore.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/state-restore-hidden.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/state-restore-to-non-autocomplete-form.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/state-restore-to-non-edited-controls.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/state-save-of-detached-control.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/location-redirect-user-gesture.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/location-redirect-user-gesture-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/history-back-initial-vs-final-url.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/history-back-initial-vs-final-url-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/history-length-append-subframe-no-hash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/history-length-append-subframe-no-hash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/history-length-append-subframe-with-hash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/history-length-append-subframe-with-hash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/history/resources/alert-then-back.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/history/resources/back-on-load.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/saves-state-after-fragment-nav.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/form-state-restore-with-frames.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/redirect-with-open-subframe.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/redirect-with-open-subframe-2.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/reload-zero-byte-plugin.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/reload-zero-byte-plugin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/scroll-position-restoration-without-premature-clamping.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/scroll-position-restored-on-back-at-load-event.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/stateobjects/pushstate-in-data-url-denied.html View 1 chunk +11 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/stateobjects/pushstate-in-data-url-denied-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/geolocation-api/clear-watch-invalid-id-crash.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/geolocation-api/notimer-after-unload.html View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/appcache/fail-on-update.html View 1 chunk +1 line, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/appcache/resources/notify-no-crash.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/loading/onload-vs-immediate-refresh.pl View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/loading/resources/notify-success-on-load.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/misc/resources/alert-then-back.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/misc/resources/notify-success.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/timer-vs-loading.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/originHeader/origin-header-for-data.html View 1 chunk +10 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/originHeader/origin-header-for-data-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-when-allowed.html View 1 chunk +10 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/send-on-abort.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/send-on-abort-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/tracing/resources/hello.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/adopt-node-crash.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/resources/back.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/resources/notify-success.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
meacer
3 years, 9 months ago (2017-03-08 20:50:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28845e05d13bf0da3e4d8b2f483c9f537f6562dd.

Powered by Google App Engine
This is Rietveld 408576698