Replace createCrossThreadTask with crossThreadBind in webdatabase

Replace createCrossThreadTask with crossThreadBind in webdatabase

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927
Review-Url: https://codereview.chromium.org/2741443003
Cr-Commit-Position: refs/heads/master@{#456043}
Committed: https://chromium.googlesource.com/chromium/src/+/ff80830195cffa6ffb66ccbef546ff4a0f758a5f

[yuryu, 2017-03-08 08:12:44]

The CQ bit was checked by yuryu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 08:13:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 09:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 09:52:59]

Dry run: This issue passed the CQ dry run.

[yuryu, 2017-03-09 01:34:38]

Description was changed from

==========
Replace createCrossThreadTask with crossThreadBind

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behaviour remains the same as Document::postTask forwards tasks to
WebTaskRunner.

BUG=625927
==========

to

==========
Replace createCrossThreadTask with crossThreadBind in webdatabase

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927
==========

[yuryu, 2017-03-09 01:35:51]

yuryu@chromium.org changed reviewers:
+ nhiroki@chromium.org, tzik@chromium.org

[yuryu, 2017-03-09 01:35:51]

please take a look, thanks

[nhiroki, 2017-03-09 05:53:08]

As offline chat, TaskRunenrHelper is not available on non-main threads. Instead,
can you keep thread-safe RefPtr<WebTaskRunner> on the main thread and then post
a task to the task runner from non-main threads?

[yuryu, 2017-03-09 06:49:15]

On 2017/03/09 05:53:08, nhiroki (slow) wrote:
> As offline chat, TaskRunenrHelper is not available on non-main threads.
Instead,
> can you keep thread-safe RefPtr<WebTaskRunner> on the main thread and then
post
> a task to the task runner from non-main threads?

done

[yuryu, 2017-03-09 07:04:35]

It might be better to add Database::postTask() that posts to m_webTaskRunner
instead of exposing an entire WebTaskRunner by getWebTaskRunner(). 
What do you think?

[nhiroki, 2017-03-09 07:59:56]

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/Database.h (right):

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/Database.h:118:
RefPtr<WebTaskRunner> getWebTaskRunner() const;
getDatabaseTaskRunenr()?

Can you return WebTaskRunner& or WebTaskRunner* to avoid
incrementing/decrementing the refcount?

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/Database.h:182:
RefPtr<WebTaskRunner> m_webTaskRunner;
How about m_databaseTaskRunner? It could be clearer where a posted task runs.

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h (right):

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h:101:
RefPtr<WebTaskRunner> m_webTaskRunner;
unused?

[nhiroki, 2017-03-09 08:03:34]

On 2017/03/09 07:04:35, yuryu wrote:
> It might be better to add Database::postTask() that posts to m_webTaskRunner
> instead of exposing an entire WebTaskRunner by getWebTaskRunner(). 
> What do you think?

I'd prefer getDatabaseTaskRunner() because Database::postTask() doesn't explain
where a posted task runs.

[yuryu, 2017-03-09 08:35:48]

> I'd prefer getDatabaseTaskRunner() because Database::postTask() doesn't
explain
> where a posted task runs.

Agreed. Renamed the method to getDatabaseTaskRunner()

[yuryu, 2017-03-09 08:38:27]

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/Database.h (right):

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/Database.h:118:
RefPtr<WebTaskRunner> getWebTaskRunner() const;
On 2017/03/09 07:59:56, nhiroki (slow) wrote:
> getDatabaseTaskRunenr()?
> 
> Can you return WebTaskRunner& or WebTaskRunner* to avoid
> incrementing/decrementing the refcount?

Done.

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/Database.h:182:
RefPtr<WebTaskRunner> m_webTaskRunner;
On 2017/03/09 07:59:56, nhiroki (slow) wrote:
> How about m_databaseTaskRunner? It could be clearer where a posted task runs.

Done.

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h (right):

https://codereview.chromium.org/2741443003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h:101:
RefPtr<WebTaskRunner> m_webTaskRunner;
On 2017/03/09 07:59:56, nhiroki (slow) wrote:
> unused?

Done.

[nhiroki, 2017-03-09 09:07:39]

lgtm

https://codereview.chromium.org/2741443003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/Database.h (right):

https://codereview.chromium.org/2741443003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/Database.h:181: // DatabaseContext
for later use as the constructor runs in the main thread.
s/DatabaseContext/TaskType::DatabaseAccess/ ?

[tzik, 2017-03-09 23:54:11]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 23:55:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-03-09 23:59:04]

lgtm

[commit-bot: I haz the power, 2017-03-10 03:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 03:29:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yuryu, 2017-03-10 06:00:56]

yuryu@chromium.org changed reviewers:
+ haraken@chromium.org

[yuryu, 2017-03-10 06:00:57]

haraken, please take a look, thanks.

https://codereview.chromium.org/2741443003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/Database.h (right):

https://codereview.chromium.org/2741443003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/Database.h:181: // DatabaseContext
for later use as the constructor runs in the main thread.
On 2017/03/09 09:07:39, nhiroki (slow) wrote:
> s/DatabaseContext/TaskType::DatabaseAccess/ ?

Done.

[haraken, 2017-03-10 08:49:25]

LGTM

nhiroki: I'm not sure what we should do in long term though. IMHO it would be
nicer to make TaskRunnerHelper thread-safe so that developers can always use
TaskRunnerHelper when they post a task to the main thread.

[yuryu, 2017-03-10 10:34:02]

The CQ bit was checked by yuryu@chromium.org

[yuryu, 2017-03-10 10:34:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
nhiroki@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2741443003/#ps80001
(title: "comment")

[commit-bot: I haz the power, 2017-03-10 10:34:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 12:03:19]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489142042372960,
"parent_rev": "039895d69bd49f30bf762e7ab5c8812211998f16", "commit_rev":
"ff80830195cffa6ffb66ccbef546ff4a0f758a5f"}

[commit-bot: I haz the power, 2017-03-10 12:03:57]

Description was changed from

==========
Replace createCrossThreadTask with crossThreadBind in webdatabase

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927
==========

to

==========
Replace createCrossThreadTask with crossThreadBind in webdatabase

createCrossThreadTask and ExecutionContextTask are deprecated in favor
of crossThreadBind and CrossThreadClosure respectively. This patch
removes the deprecated versions. This patch also changes the code to
post tasks to WebTaskRunner instead of ExecutionContext, but the
behavour remains the same as Document::postTask already forwards tasks to
WebTaskRunner of the LocalFrame in the Document.

BUG=625927

Review-Url: https://codereview.chromium.org/2741443003
Cr-Commit-Position: refs/heads/master@{#456043}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff80830195cffa6ffb66ccbef546...
==========

[commit-bot: I haz the power, 2017-03-10 12:03:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ff80830195cffa6ffb66ccbef546...