Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 2741433002: Fix ResourceDispatcherHostDelegate::OnResponseStarted not getting called for navigation requests (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, Randy Smith (Not in Mondays), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ResourceDispatcherHostDelegate::OnResponseStarted not getting called for navigation requests. It was being called by AsyncResourceHandler which isn't used for navigation requests. Move the call to ResourceDispatcherHostImpl instead. This fixes org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnGoogleCom org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnGoogleCom_with__--webview-sandboxed-renderer_ org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnNonGoogle org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginOnNonGoogle_with__--webview-sandboxed-renderer_ org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginWithNullAccount org.chromium.android_webview.test.AwContentsClientAutoLoginTest_testAutoLoginWithNullAccount_with__--webview-sandboxed-renderer_ with PlzNavigate. BUG=645983 Review-Url: https://codereview.chromium.org/2741433002 Cr-Commit-Position: refs/heads/master@{#455671} Committed: https://chromium.googlesource.com/chromium/src/+/339b2ea6f222dcdaa3036e6e47f8aa1300343f38

Patch Set 1 #

Patch Set 2 : without PlzNavigate #

Patch Set 3 : fix mojo unittests #

Patch Set 4 : fix mojo unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -46 lines) Patch
M content/browser/loader/DEPS View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 1 2 3 10 chunks +1 line, -23 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_loader_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 24 (20 generated)
jam
3 years, 9 months ago (2017-03-08 01:23:02 UTC) #12
sgurun-gerrit only
On 2017/03/08 01:23:02, jam wrote: lgtm
3 years, 9 months ago (2017-03-08 17:49:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741433002/60001
3 years, 9 months ago (2017-03-09 03:45:03 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 05:16:19 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/339b2ea6f222dcdaa3036e6e47f8...

Powered by Google App Engine
This is Rietveld 408576698