Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2741413008: Introduce flag to disable static popular sites. (Closed)

Created:
3 years, 9 months ago by fhorschig
Modified:
3 years, 9 months ago
Reviewers:
sfiera
CC:
chromium-reviews, srahim+watch_chromium.org, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce flag to disable static popular sites. In order to disable the global static defaults while having popular sites enabled, a separate flag is necessary. BUG=700872 Review-Url: https://codereview.chromium.org/2741413008 Cr-Commit-Position: refs/heads/master@{#457403} Committed: https://chromium.googlesource.com/chromium/src/+/f84f9f576720345c30d23204e6329ed2204d1903

Patch Set 1 #

Patch Set 2 : Use flag to prevent loading the default list #

Patch Set 3 : Use param instead of new trial #

Total comments: 2

Patch Set 4 : Use feature instead of params #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
M components/ntp_tiles/constants.h View 1 2 3 1 chunk +10 lines, -1 line 0 comments Download
M components/ntp_tiles/constants.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M components/ntp_tiles/popular_sites_impl.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M components/ntp_tiles/popular_sites_impl_unittest.cc View 1 2 3 7 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
fhorschig
Hi Chris, would you please take a look at the new flag that disables the ...
3 years, 9 months ago (2017-03-15 13:21:04 UTC) #6
fhorschig
On 2017/03/15 13:21:04, fhorschig wrote: > Hi Chris, > would you please take a look ...
3 years, 9 months ago (2017-03-15 15:09:16 UTC) #7
fhorschig
Hi Chris, it's simplified and ready to review!
3 years, 9 months ago (2017-03-16 10:01:49 UTC) #8
sfiera
https://codereview.chromium.org/2741413008/diff/40001/components/ntp_tiles/field_trial.cc File components/ntp_tiles/field_trial.cc (right): https://codereview.chromium.org/2741413008/diff/40001/components/ntp_tiles/field_trial.cc#newcode67 components/ntp_tiles/field_trial.cc:67: const std::string& trial_value = base::GetFieldTrialParamValue( Three things: * I ...
3 years, 9 months ago (2017-03-16 10:15:41 UTC) #9
fhorschig
https://codereview.chromium.org/2741413008/diff/40001/components/ntp_tiles/field_trial.cc File components/ntp_tiles/field_trial.cc (right): https://codereview.chromium.org/2741413008/diff/40001/components/ntp_tiles/field_trial.cc#newcode67 components/ntp_tiles/field_trial.cc:67: const std::string& trial_value = base::GetFieldTrialParamValue( On 2017/03/16 10:15:40, sfiera ...
3 years, 9 months ago (2017-03-16 10:57:50 UTC) #11
sfiera
LGTM
3 years, 9 months ago (2017-03-16 11:10:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741413008/80001
3 years, 9 months ago (2017-03-16 12:10:35 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 12:14:52 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f84f9f576720345c30d23204e632...

Powered by Google App Engine
This is Rietveld 408576698