Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: ios/web/public/navigation_manager.h

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)
Patch Set: Rebase and Remove DCHECK in |loadWithParams| as it has already been taken care of Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/navigation_manager_impl_unittest.mm ('k') | ios/web/web_state/ui/crw_web_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/navigation_manager.h
diff --git a/ios/web/public/navigation_manager.h b/ios/web/public/navigation_manager.h
index a8b1cf57f714c357f129a7150cb382e35838b50b..2fd5e061d0cd3ae768c87751f7fa871d74dd730d 100644
--- a/ios/web/public/navigation_manager.h
+++ b/ios/web/public/navigation_manager.h
@@ -153,9 +153,9 @@ class NavigationManager {
// Reloads the visible item under the specified ReloadType. If
// |check_for_repost| is true and the current item has POST data the user is
- // prompted to see if they really want to reload the page. In nearly all cases
- // pass in true. If a transient item is showing, initiates a new navigation
- // to its URL.
+ // prompted to see if they really want to reload the page. Pass in true if the
+ // reload is explicitly initiated by the user. If a transient item is showing,
+ // initiates a new navigation to its URL.
// TODO(crbug.com/700571): implement the logic for when |reload_type| is
// ORIGINAL_REQUEST_URL.
// TODO(crbug.com/700958): implement the logic for |check_for_repost|.
« no previous file with comments | « ios/web/navigation/navigation_manager_impl_unittest.mm ('k') | ios/web/web_state/ui/crw_web_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698