ios/web/web_state/ui/crw_web_controller.h - Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.h

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)

Patch Set: Rebase and Remove DCHECK in |loadWithParams| as it has already been taken care of Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.h

diff --git a/ios/web/web_state/ui/crw_web_controller.h b/ios/web/web_state/ui/crw_web_controller.h

index 74dbe83cdf416884da50b04f292687634740e2ad..b7706278b98e7d772674bceb418ae1ce6dd2c5d0 100644

--- a/ios/web/web_state/ui/crw_web_controller.h

+++ b/ios/web/web_state/ui/crw_web_controller.h

@@ -153,8 +153,10 @@ class WebStateImpl;

// to generate an overlay placeholder view.

- (BOOL)canUseViewForGeneratingOverlayPlaceholderView;

-// Start loading the URL specified in |originalParams|, with the specified

+// Start loading the URL specified in |params|, with the specified

// settings. Always resets the openedByScript property to NO.

+// NOTE: |params.transition_type| should never be PAGE_TRANSITION_RELOAD except

+// for transient items, if one needs to reload, call |-reload| explicitly.

- (void)loadWithParams:(const web::NavigationManager::WebLoadParams&)params;

// Loads the URL indicated by current session state.

« no previous file with comments | « ios/web/public/navigation_manager.h ('k') | ios/web/web_state/web_state_impl.h » ('j') | no next file with comments »