mash: Update LoginStatus with session state updates

mash: Update LoginStatus with session state updates

In classic ash, chrome calls WmShell::UpdateUserLoginStatus() directly,
which updates the appearance of the system tray menu, status area
notifications icon, etc.

Fix mash so it updates LoginStatus as well so that the system tray menu
works more similarly to classic ash. (For example, it now hides the
notifications icon during oobe, hides the "sign out" item in the system
tray menu at the login screen, etc.)

BUG=699234, 648964
TEST=added to ash_unittests SessionControllerTest

Review-Url: https://codereview.chromium.org/2741403004
Cr-Commit-Position: refs/heads/master@{#456540}
Committed: https://chromium.googlesource.com/chromium/src/+/063733f75d45987b9db79b3e423603908bb558d0

[James Cook, 2017-03-13 22:34:24]

Description was changed from

==========
mash: Update LoginStatus with session state updates

In classic ash, chrome calls WmShell::UpdateUserLoginStatus() directly,
which updates the appearance of the system tray menu, status area
notifications icon, etc.

Fix mash so it updates LoginStatus as well so that the system tray menu
works more similarly to classic ash. (For example, it now hides the
notifications icon during oobe, hides the "sign out" item in the system
tray menu at the login screen, etc.)

BUG=699234,648964
TEST=added to ash_unittests SessionControllerTest
==========

to

==========
mash: Update LoginStatus with session state updates

In classic ash, chrome calls WmShell::UpdateUserLoginStatus() directly,
which updates the appearance of the system tray menu, status area
notifications icon, etc.

Fix mash so it updates LoginStatus as well so that the system tray menu
works more similarly to classic ash. (For example, it now hides the
notifications icon during oobe, hides the "sign out" item in the system
tray menu at the login screen, etc.)

BUG=699234,648964
TEST=added to ash_unittests SessionControllerTest
==========

[James Cook, 2017-03-13 22:36:45]

jamescook@chromium.org changed reviewers:
+ xiyuan@chromium.org

[James Cook, 2017-03-13 22:36:45]

xiyuan, please take a look.

I called this a "hack" in the code, but I think we might actually want to keep
something like this.

[James Cook, 2017-03-13 22:36:51]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 22:37:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-03-13 22:56:05]

lgtm

Cool

[James Cook, 2017-03-13 23:07:52]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-03-13 23:07:58]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:08:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 23:27:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489446478588690, "parent_rev":
"ead4ab4ffb0784d727e827d901d708b38a1cefe1", "commit_rev":
"063733f75d45987b9db79b3e423603908bb558d0"}

[commit-bot: I haz the power, 2017-03-13 23:28:41]

Description was changed from

==========
mash: Update LoginStatus with session state updates

In classic ash, chrome calls WmShell::UpdateUserLoginStatus() directly,
which updates the appearance of the system tray menu, status area
notifications icon, etc.

Fix mash so it updates LoginStatus as well so that the system tray menu
works more similarly to classic ash. (For example, it now hides the
notifications icon during oobe, hides the "sign out" item in the system
tray menu at the login screen, etc.)

BUG=699234,648964
TEST=added to ash_unittests SessionControllerTest
==========

to

==========
mash: Update LoginStatus with session state updates

In classic ash, chrome calls WmShell::UpdateUserLoginStatus() directly,
which updates the appearance of the system tray menu, status area
notifications icon, etc.

Fix mash so it updates LoginStatus as well so that the system tray menu
works more similarly to classic ash. (For example, it now hides the
notifications icon during oobe, hides the "sign out" item in the system
tray menu at the login screen, etc.)

BUG=699234,648964
TEST=added to ash_unittests SessionControllerTest

Review-Url: https://codereview.chromium.org/2741403004
Cr-Commit-Position: refs/heads/master@{#456540}
Committed:
https://chromium.googlesource.com/chromium/src/+/063733f75d45987b9db79b3e4236...
==========

[commit-bot: I haz the power, 2017-03-13 23:28:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/063733f75d45987b9db79b3e4236...