Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2741343018: cros: test coverage of shelf alignment initialization for guest session (Closed)

Created:
3 years, 9 months ago by Qiang(Joe) Xu
Modified:
3 years, 9 months ago
Reviewers:
msw, James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: test coverage of shelf alignment initialization for guest session BUG=699661 BUG=702014 TEST=automated tests Review-Url: https://codereview.chromium.org/2741343018 Cr-Commit-Position: refs/heads/master@{#457568} Committed: https://chromium.googlesource.com/chromium/src/+/82d4b66fd8df31637f3a9cdbb4ada8a00b6b3781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/browser/ui/ash/shelf_browsertest.cc View 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Qiang(Joe) Xu
Hi all, PTAL, thanks!
3 years, 9 months ago (2017-03-16 19:00:24 UTC) #5
James Cook
LGTM. Thanks for adding the test!
3 years, 9 months ago (2017-03-16 19:22:16 UTC) #8
msw
nice; thanks for adding this test! lgtm
3 years, 9 months ago (2017-03-16 21:23:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741343018/1
3 years, 9 months ago (2017-03-16 21:29:39 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 21:43:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82d4b66fd8df31637f3a9cdbb4ad...

Powered by Google App Engine
This is Rietveld 408576698