Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 2741343015: Add a BrowserState* parameter to GetEarlyPageScript(). (Closed)

Created:
3 years, 9 months ago by Hiroshi Ichikawa
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a BrowserState* parameter to GetEarlyPageScript(). This is required to implement crbug.com/698656. BUG=698656 Review-Url: https://codereview.chromium.org/2741343015 Cr-Commit-Position: refs/heads/master@{#457701} Committed: https://chromium.googlesource.com/chromium/src/+/303f5b11ca5701fd3410ad0c559fb6a88f832c71

Patch Set 1 #

Patch Set 2 : Fix a test. #

Patch Set 3 : Fix errors. #

Total comments: 4

Patch Set 4 : Apply review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -33 lines) Patch
M ios/chrome/browser/web/chrome_web_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/chrome_web_client.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/web/chrome_web_client_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/early_page_script_perftest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/test/fakes/test_web_client.h View 2 chunks +3 lines, -1 line 0 comments Download
M ios/web/public/test/fakes/test_web_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/crw_js_window_id_manager_unittest.mm View 1 2 3 5 chunks +15 lines, -7 lines 0 comments Download
M ios/web/web_state/js/page_script_util.h View 1 chunk +3 lines, -1 line 0 comments Download
M ios/web/web_state/js/page_script_util.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/web/web_state/js/page_script_util_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider.h View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 2 3 4 chunks +7 lines, -8 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Hiroshi Ichikawa
3 years, 9 months ago (2017-03-16 09:00:56 UTC) #3
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2741343015/diff/40001/ios/web/web_state/js/crw_js_window_id_manager_unittest.mm File ios/web/web_state/js/crw_js_window_id_manager_unittest.mm (left): https://codereview.chromium.org/2741343015/diff/40001/ios/web/web_state/js/crw_js_window_id_manager_unittest.mm#oldcode14 ios/web/web_state/js/crw_js_window_id_manager_unittest.mm:14: nit: Please add comment: "Test fixture for testing ...
3 years, 9 months ago (2017-03-16 16:12:40 UTC) #4
Hiroshi Ichikawa
https://codereview.chromium.org/2741343015/diff/40001/ios/web/web_state/js/crw_js_window_id_manager_unittest.mm File ios/web/web_state/js/crw_js_window_id_manager_unittest.mm (left): https://codereview.chromium.org/2741343015/diff/40001/ios/web/web_state/js/crw_js_window_id_manager_unittest.mm#oldcode14 ios/web/web_state/js/crw_js_window_id_manager_unittest.mm:14: On 2017/03/16 16:12:40, Eugene But wrote: > nit: Please ...
3 years, 9 months ago (2017-03-17 06:09:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741343015/60001
3 years, 9 months ago (2017-03-17 06:10:14 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 06:43:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/303f5b11ca5701fd3410ad0c559f...

Powered by Google App Engine
This is Rietveld 408576698