Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2741343011: [Payments] Move PersonalDataManager and locale to PaymentRequestState (Closed)

Created:
3 years, 9 months ago by Mathieu
Modified:
3 years, 9 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Move PersonalDataManager and locale to PaymentRequestState Also moving the CurrencyFormatter to PaymentRequestSpec BUG=701345 TEST=existing Review-Url: https://codereview.chromium.org/2741343011 Cr-Commit-Position: refs/heads/master@{#457074} Committed: https://chromium.googlesource.com/chromium/src/+/c0d616afe2d5fb6069007fbbd4899eb257a7f6fc

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -124 lines) Patch
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/order_summary_view_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 5 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/payments/profile_list_view_controller.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_option_view_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/payments/content/payment_request.h View 5 chunks +0 lines, -26 lines 0 comments Download
M components/payments/content/payment_request.cc View 4 chunks +5 lines, -39 lines 0 comments Download
M components/payments/content/payment_request_spec.h View 4 chunks +24 lines, -1 line 0 comments Download
M components/payments/content/payment_request_spec.cc View 3 chunks +32 lines, -2 lines 0 comments Download
M components/payments/content/payment_request_spec_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/payments/content/payment_request_state.h View 5 chunks +11 lines, -5 lines 0 comments Download
M components/payments/content/payment_request_state.cc View 8 chunks +22 lines, -12 lines 0 comments Download
M components/payments/content/payment_request_state_unittest.cc View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Mathieu
Anthony, PTAL!
3 years, 9 months ago (2017-03-15 13:20:31 UTC) #9
anthonyvd
lgtm, awesome!
3 years, 9 months ago (2017-03-15 13:31:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741343011/40001
3 years, 9 months ago (2017-03-15 13:34:28 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 14:10:23 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c0d616afe2d5fb6069007fbbd489...

Powered by Google App Engine
This is Rietveld 408576698