Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2741343004: [Web Payments] Use shipping type in the header of the Shipping Address sheet. (Closed)

Created:
3 years, 9 months ago by anthonyvd
Modified:
3 years, 9 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Use shipping type in the header of the Shipping Address sheet. BUG=700499 Review-Url: https://codereview.chromium.org/2741343004 Cr-Commit-Position: refs/heads/master@{#456587} Committed: https://chromium.googlesource.com/chromium/src/+/ff263391641f59daed81c273d9eb28a390759239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/payments/profile_list_view_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
anthonyvd
Hey Math, huge change here. Can you PTAL? Thanks!
3 years, 9 months ago (2017-03-13 18:48:06 UTC) #2
Mathieu
lgtm
3 years, 9 months ago (2017-03-13 23:54:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741343004/1
3 years, 9 months ago (2017-03-13 23:54:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/407900)
3 years, 9 months ago (2017-03-14 00:49:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741343004/1
3 years, 9 months ago (2017-03-14 00:59:54 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 02:37:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff263391641f59daed81c273d9eb...

Powered by Google App Engine
This is Rietveld 408576698