[Autofill] Preserve use stats of existing Wallet cards when syncing.

[Autofill] Preserve use stats of existing Wallet cards when syncing.

Load the use stats from disk when saving Wallet Cards.

Add specific logic to overwrite a Wallet card use data in case the
metadata gets delayed. The previous logic was keep most recent which
resulted in making old card seem like they were just used.

BUG=700486
Review-Url: https://codereview.chromium.org/2741233002
Cr-Commit-Position: refs/heads/master@{#456395}
Committed: https://chromium.googlesource.com/chromium/src/+/109e10b0a48a1f09d242562611c2556b12a29da6

[sebsg, 2017-03-10 20:30:31]

Patchset #1 (id:1) has been deleted

[sebsg, 2017-03-10 20:30:56]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-03-10 20:30:57]

Hi Math, could you please take a look? Thanks!

[Mathieu, 2017-03-10 21:04:01]

lgtm

https://codereview.chromium.org/2741233002/diff/20001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
(right):

https://codereview.chromium.org/2741233002/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc:175:
// use_count > 1 should always be prefered.
*preferred

https://codereview.chromium.org/2741233002/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc:182:
} else {
else if?

[sebsg, 2017-03-13 13:53:24]

Patchset #2 (id:40001) has been deleted

[sebsg, 2017-03-13 13:54:40]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2017-03-13 13:54:41]

Hi Rouslan, PTAL?

https://codereview.chromium.org/2741233002/diff/20001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
(right):

https://codereview.chromium.org/2741233002/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc:175:
// use_count > 1 should always be prefered.
On 2017/03/10 21:04:01, Mathieu Perreault wrote:
> *preferred

Done.

https://codereview.chromium.org/2741233002/diff/20001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc:182:
} else {
On 2017/03/10 21:04:01, Mathieu Perreault wrote:
> else if?

I feel like what's in the else all comes together and it is clearer that way.
WDYT?

[please use gerrit instead, 2017-03-13 14:04:49]

lgtm % comments

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
(right):

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc:1232:
}
Add a test for identical use count and use date on local and remote, unless this
test case is already present.

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
File components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h
(right):

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h:86:
// overwrites the server version with the billing id saved on disk if it
Update the comment.

[sebsg, 2017-03-13 15:35:45]

Thanks, sending to CQ

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
File
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
(right):

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc:1232:
}
On 2017/03/13 14:04:49, ಠ_ಠ wrote:
> Add a test for identical use count and use date on local and remote, unless
this
> test case is already present.

Already exists, it's called IgnoreIdenticalValuesOnMerge.

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
File components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h
(right):

https://codereview.chromium.org/2741233002/diff/60001/components/autofill/cor...
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h:86:
// overwrites the server version with the billing id saved on disk if it
On 2017/03/13 14:04:49, ಠ_ಠ wrote:
> Update the comment.

Done.

[sebsg, 2017-03-13 15:35:48]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-03-13 15:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2741233002/#ps80001
(title: "Updated comment")

[commit-bot: I haz the power, 2017-03-13 15:36:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 16:23:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489419348699650,
"parent_rev": "41f3b13b61278aa9aa7660b6acfd22091cdc75e5", "commit_rev":
"109e10b0a48a1f09d242562611c2556b12a29da6"}

[commit-bot: I haz the power, 2017-03-13 16:24:44]

Description was changed from

==========
[Autofill] Preserve use stats of existing Wallet cards when syncing.

Load the use stats from disk when saving Wallet Cards.

Add specific logic to overwrite a Wallet card use data in case the
metadata gets delayed. The previous logic was keep most recent which
resulted in making old card seem like they were just used.

BUG=700486
==========

to

==========
[Autofill] Preserve use stats of existing Wallet cards when syncing.

Load the use stats from disk when saving Wallet Cards.

Add specific logic to overwrite a Wallet card use data in case the
metadata gets delayed. The previous logic was keep most recent which
resulted in making old card seem like they were just used.

BUG=700486

Review-Url: https://codereview.chromium.org/2741233002
Cr-Commit-Position: refs/heads/master@{#456395}
Committed:
https://chromium.googlesource.com/chromium/src/+/109e10b0a48a1f09d242562611c2...
==========

[commit-bot: I haz the power, 2017-03-13 16:24:45]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/109e10b0a48a1f09d242562611c2...