Convert LayoutTests/svg/dom/*.html js-tests.js to testharness.js based tests.

Convert LayoutTests/svg/dom/*.html js-tests.js to testharness.js based tests.

BUG=636710
Review-Url: https://codereview.chromium.org/2741153003
Cr-Commit-Position: refs/heads/master@{#456689}
Committed: https://chromium.googlesource.com/chromium/src/+/b564548ad17fbddb292f135951aefcbde141e400

[Shanmuga Pandi, 2017-03-10 05:32:29]

shanmuga.m@samsung.com changed reviewers:
+ fs@opera.com, srirama.m@samsung.com

[Shanmuga Pandi, 2017-03-10 05:32:41]

On 2017/03/10 05:32:29, Shanmuga Pandi wrote:

PTAL!
Thanks

[fs, 2017-03-10 09:58:10]

LGTM w/ nits and a comment/reflection (the first one in SVGAngle.html, no action
required on that one.)

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGAngle.html (right):

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAngle.html:6: test(function() {
A better structure for this test would have been to use several test(...)s
(roughly one per "section" probably.) I guess it is what it is though...

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAngle.html:203: angle.unitType =
SVGAngle.SVG_ANGLETTYE_RAD;
The typo (ANGLETTYE -> ANGLETYPE) on the lhs doesn't appear to be intentional. I
think test would make more sense if setting to a valid unit.

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html (right):

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html:27: matrix.a = matrix;
Looks like we're repeating ourselves here quite a bit. Maybe roll this sequence
up into a helper. ('svgElement' can be put on the global object.)

[Shanmuga Pandi, 2017-03-13 07:36:28]

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html (right):

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html:27: matrix.a = matrix;
On 2017/03/10 09:58:10, fs wrote:
> Looks like we're repeating ourselves here quite a bit. Maybe roll this
sequence
> up into a helper. ('svgElement' can be put on the global object.)

Adding helper is not working.

I have tried like this below.

function assert_equal_attr(attr) {
  attr = matrix;
  assert_equals(attr, NaN);
  attr = 0;
  assert_equals(attr, 0);
  attr = svgElement;
  assert_equals(attr, NaN);
  attr = 0;
  assert_equals(attr, 0);
  attr = 'aString';
  assert_equals(attr, NaN);
} 

and calling assert_equal_attr(matrix.a);

but many of cases not working as expected.

[fs, 2017-03-13 08:47:55]

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html (right):

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html:27: matrix.a = matrix;
On 2017/03/13 at 07:36:28, Shanmuga Pandi wrote:
> On 2017/03/10 09:58:10, fs wrote:
> > Looks like we're repeating ourselves here quite a bit. Maybe roll this
sequence
> > up into a helper. ('svgElement' can be put on the global object.)
> 
> Adding helper is not working.
> 
> I have tried like this below.
> 
> function assert_equal_attr(attr) {
>   attr = matrix;
>   assert_equals(attr, NaN);
>   attr = 0;
>   assert_equals(attr, 0);
>   attr = svgElement;
>   assert_equals(attr, NaN);
>   attr = 0;
>   assert_equals(attr, 0);
>   attr = 'aString';
>   assert_equals(attr, NaN);
> } 
> 
> and calling assert_equal_attr(matrix.a);
> 
> but many of cases not working as expected.

It would need to be something like:

function assert_matrix_component_numeric(matrix, component) {
  matrix[component] = matrix;
  assert_equals(matrix[component], NaN);
  ...
}
...
assert_matrix_component_numeric(matrix, 'a');

et.c

[Shanmuga Pandi, 2017-03-13 08:58:55]

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGAngle.html (right):

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAngle.html:203: angle.unitType =
SVGAngle.SVG_ANGLETTYE_RAD;
On 2017/03/10 09:58:10, fs wrote:
> The typo (ANGLETTYE -> ANGLETYPE) on the lhs doesn't appear to be intentional.
I
> think test would make more sense if setting to a valid unit.

Done.

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html (right):

https://codereview.chromium.org/2741153003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGMatrix.html:27: matrix.a = matrix;
On 2017/03/13 08:47:55, fs wrote:
> On 2017/03/13 at 07:36:28, Shanmuga Pandi wrote:
> > On 2017/03/10 09:58:10, fs wrote:
> > > Looks like we're repeating ourselves here quite a bit. Maybe roll this
> sequence
> > > up into a helper. ('svgElement' can be put on the global object.)
> > 
> > Adding helper is not working.
> > 
> > I have tried like this below.
> > 
> > function assert_equal_attr(attr) {
> >   attr = matrix;
> >   assert_equals(attr, NaN);
> >   attr = 0;
> >   assert_equals(attr, 0);
> >   attr = svgElement;
> >   assert_equals(attr, NaN);
> >   attr = 0;
> >   assert_equals(attr, 0);
> >   attr = 'aString';
> >   assert_equals(attr, NaN);
> > } 
> > 
> > and calling assert_equal_attr(matrix.a);
> > 
> > but many of cases not working as expected.
> 
> It would need to be something like:
> 
> function assert_matrix_component_numeric(matrix, component) {
>   matrix[component] = matrix;
>   assert_equals(matrix[component], NaN);
>   ...
> }
> ...
> assert_matrix_component_numeric(matrix, 'a');
> 
> et.c

Done.

[Shanmuga Pandi, 2017-03-14 12:38:16]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2017-03-14 12:38:16]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2741153003/#ps20001
(title: "Align with review comments")

[commit-bot: I haz the power, 2017-03-14 12:38:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 13:40:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489495096391880,
"parent_rev": "34de5e81971ebe3a3944959b5a03ca9ebeb6621d", "commit_rev":
"b564548ad17fbddb292f135951aefcbde141e400"}

[commit-bot: I haz the power, 2017-03-14 13:41:00]

Description was changed from

==========
Convert LayoutTests/svg/dom/*.html js-tests.js to testharness.js based tests.

BUG=636710
==========

to

==========
Convert LayoutTests/svg/dom/*.html js-tests.js to testharness.js based tests.

BUG=636710

Review-Url: https://codereview.chromium.org/2741153003
Cr-Commit-Position: refs/heads/master@{#456689}
Committed:
https://chromium.googlesource.com/chromium/src/+/b564548ad17fbddb292f135951ae...
==========

[commit-bot: I haz the power, 2017-03-14 13:41:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b564548ad17fbddb292f135951ae...