Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Issue 2741143002: Simplify LayoutTextFragment constructor. (Closed)

Created:
3 years, 9 months ago by emilio
Modified:
3 years, 9 months ago
Reviewers:
Manuel Rego
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify LayoutTextFragment constructor. Just a simple cleanup I saw while working on https://codereview.chromium.org/2727853002 Review-Url: https://codereview.chromium.org/2741143002 Cr-Commit-Position: refs/heads/master@{#456082} Committed: https://chromium.googlesource.com/chromium/src/+/fb37238e488514082277b2e25ed1ff1b97be0fe9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
emilio
Hey rego, could you review this? Should be a trivial cleanup, no behavior change.
3 years, 9 months ago (2017-03-10 13:51:24 UTC) #6
Manuel Rego
lgtm
3 years, 9 months ago (2017-03-10 16:48:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741143002/1
3 years, 9 months ago (2017-03-10 16:48:48 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 16:53:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb37238e488514082277b2e25ed1...

Powered by Google App Engine
This is Rietveld 408576698