Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2741133003: ntp_snippets: Use base::EraseIf() (Closed)

Created:
3 years, 9 months ago by sfiera
Modified:
3 years, 9 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ntp_snippets: Use base::EraseIf() BUG=None Review-Url: https://codereview.chromium.org/2741133003 Cr-Commit-Position: refs/heads/master@{#456099} Committed: https://chromium.googlesource.com/chromium/src/+/fd23b83100cfe96d872c45d61b51d0f878110f8d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -56 lines) Patch
M components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc View 1 5 chunks +21 lines, -23 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl.cc View 5 chunks +21 lines, -33 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sfiera
3 years, 9 months ago (2017-03-10 10:22:20 UTC) #4
Marc Treib
lgtm I also saw that announcement email :) Nice! Description nit: Add "ntp_snippets: " to ...
3 years, 9 months ago (2017-03-10 10:38:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741133003/20001
3 years, 9 months ago (2017-03-10 17:15:13 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 17:56:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fd23b83100cfe96d872c45d61b51...

Powered by Google App Engine
This is Rietveld 408576698