Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2741103003:
Simplify ComputedStyleBase::inheritedEqual. (Closed)
DescriptionSimplify ComputedStyleBase::inheritedEqual.
Currently ComputedStyleBase::inheritedEqual just does a pairwise compare
over all inherited properties. A more concise implementation is to use
the existing independentInheritedEqual and nonIndependentInheritedEqual
methods. This is what ComputedStyle does. We can switch to a more
efficient when we can think of one.
BUG=628043
Review-Url: https://codereview.chromium.org/2741103003
Cr-Commit-Position: refs/heads/master@{#456995}
Committed: https://chromium.googlesource.com/chromium/src/+/44a3e217dedd16eea0ac435e1444e7980586f634
Patch Set 1 #
Messages
Total messages: 23 (17 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
shend@chromium.org changed reviewers: + bugsnash@chromium.org
Hi Bugs, PTAL
lgtm
shend@chromium.org changed reviewers: + meade@chromium.org
Hi Eddy, PTAL
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489551697659770, "parent_rev":
"2788f301163707f68b164224a3b0b672b47fca30", "commit_rev":
"44a3e217dedd16eea0ac435e1444e7980586f634"}
Message was sent while issue was closed.
Description was changed from ========== Simplify ComputedStyleBase::inheritedEqual. Currently ComputedStyleBase::inheritedEqual just does a pairwise compare over all inherited properties. A more concise implementation is to use the existing independentInheritedEqual and nonIndependentInheritedEqual methods. This is what ComputedStyle does. We can switch to a more efficient when we can think of one. BUG=628043 ========== to ========== Simplify ComputedStyleBase::inheritedEqual. Currently ComputedStyleBase::inheritedEqual just does a pairwise compare over all inherited properties. A more concise implementation is to use the existing independentInheritedEqual and nonIndependentInheritedEqual methods. This is what ComputedStyle does. We can switch to a more efficient when we can think of one. BUG=628043 Review-Url: https://codereview.chromium.org/2741103003 Cr-Commit-Position: refs/heads/master@{#456995} Committed: https://chromium.googlesource.com/chromium/src/+/44a3e217dedd16eea0ac435e1444... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/44a3e217dedd16eea0ac435e1444... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
