Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2741053004: s390: cleanup old instruction decode routines (Closed)

Created:
3 years, 9 months ago by john.yan
Modified:
3 years, 9 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: cleanup old instruction decode routines R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2741053004 Cr-Commit-Position: refs/heads/master@{#43732} Committed: https://chromium.googlesource.com/v8/v8/+/55e3fb94ac9d1487100a958ca0ad467d61d47440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3167 lines) Patch
M src/s390/simulator-s390.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/s390/simulator-s390.cc View 2 chunks +0 lines, -3155 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
john.yan
ptal
3 years, 9 months ago (2017-03-10 19:09:14 UTC) #1
JoranSiu
On 2017/03/10 19:09:14, john.yan wrote: > ptal Lgtm
3 years, 9 months ago (2017-03-10 21:47:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741053004/1
3 years, 9 months ago (2017-03-12 04:13:09 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-12 04:40:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/55e3fb94ac9d1487100a958ca0ad467d61d...

Powered by Google App Engine
This is Rietveld 408576698