Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2741043002: Update waterfall testing config for AutofillCreditCardDropdownVariations (Closed)

Created:
3 years, 9 months ago by Jared Saul
Modified:
3 years, 9 months ago
Reviewers:
*rkaplow
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update waterfall testing config for AutofillCreditCardDropdownVariations Update waterfall testing config for AutofillCreditCardDropdownVariations BUG= Review-Url: https://codereview.chromium.org/2741043002 Cr-Commit-Position: refs/heads/master@{#456217} Committed: https://chromium.googlesource.com/chromium/src/+/b51fdeba0612b601ae9477c2c4364272dd54154f

Patch Set 1 #

Patch Set 2 : Spoke with rkaplow@, putting both current features in the trybots test #

Patch Set 3 : Remove AutofillCreditCardPopup waterfall config (until launch time) as the Android trybot doesn't a… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 2 1 chunk +3 lines, -19 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
Jared Saul
Hi Robert, PTAL. This is following up on a comment in cl/149559994. Thanks!
3 years, 9 months ago (2017-03-09 19:39:34 UTC) #3
rkaplow
lgtm
3 years, 9 months ago (2017-03-09 20:27:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741043002/1
3 years, 9 months ago (2017-03-09 20:43:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/134128)
3 years, 9 months ago (2017-03-09 22:00:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741043002/1
3 years, 9 months ago (2017-03-10 01:46:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/134391)
3 years, 9 months ago (2017-03-10 03:08:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741043002/20001
3 years, 9 months ago (2017-03-10 20:28:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/248291)
3 years, 9 months ago (2017-03-10 21:20:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741043002/40001
3 years, 9 months ago (2017-03-10 21:38:16 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/406795)
3 years, 9 months ago (2017-03-10 23:00:17 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741043002/40001
3 years, 9 months ago (2017-03-10 23:10:30 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 23:34:34 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b51fdeba0612b601ae9477c2c436...

Powered by Google App Engine
This is Rietveld 408576698