Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2740993002: Remove unused instant_overlay_controller_mac.h/mm (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, mac-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused instant_overlay_controller_mac.h/mm This hasn't been used in a *long* time. It's not referenced in any build files, and its supposed base class doesn't exist anymore. BUG=627747 Review-Url: https://codereview.chromium.org/2740993002 Cr-Commit-Position: refs/heads/master@{#455896} Committed: https://chromium.googlesource.com/chromium/src/+/4fe3a084bcf7a2782c29498761186eac282306b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -68 lines) Patch
D chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.mm View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Marc Treib
PTAL at this tiny cleanup. Thanks!
3 years, 9 months ago (2017-03-09 17:12:51 UTC) #6
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-09 18:51:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740993002/1
3 years, 9 months ago (2017-03-09 23:02:46 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 23:29:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4fe3a084bcf7a2782c2949876118...

Powered by Google App Engine
This is Rietveld 408576698