Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2740953006: cros: WIP patch to remove DeviceDisabledScreenView.

Created:
3 years, 9 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: WIP patch to remove DeviceDisabledScreenView. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -152 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/core_oobe_view.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/core_oobe_view.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/device_disabled_screen.h View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screens/device_disabled_screen.cc View 3 chunks +7 lines, -7 lines 0 comments Download
D chrome/browser/chromeos/login/screens/device_disabled_screen_view.h View 1 chunk +0 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_core_oobe_view.h View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/chromeos/login/screens/mock_device_disabled_screen_view.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/chromeos/login/screens/mock_device_disabled_screen_view.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.h View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc View 4 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (4 generated)
jdufault
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-10 23:45:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740953006/1
3 years, 9 months ago (2017-03-10 23:45:38 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-11 01:24:52 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 01:24:53 UTC) #4 
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698