Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2740953005: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file( signin, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=rogerta@chromium.org Review-Url: https://codereview.chromium.org/2740953005 Cr-Commit-Position: refs/heads/master@{#456191} Committed: https://chromium.googlesource.com/chromium/src/+/094b5e38f83ceebb408911139f194dd3705e54be

Patch Set 1 #

Total comments: 6

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/extensions/signin/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/signin/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 22:00:54 UTC) #1
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/2740953005/diff/1/chrome/browser/extensions/signin/OWNERS File chrome/browser/extensions/signin/OWNERS (right): https://codereview.chromium.org/2740953005/diff/1/chrome/browser/extensions/signin/OWNERS#newcode2 chrome/browser/extensions/signin/OWNERS:2: guohui@chromium.org Since you are here, could you remove guohui@ ...
3 years, 9 months ago (2017-03-10 22:06:33 UTC) #2
ymzhang1
https://codereview.chromium.org/2740953005/diff/1/chrome/browser/extensions/signin/OWNERS File chrome/browser/extensions/signin/OWNERS (right): https://codereview.chromium.org/2740953005/diff/1/chrome/browser/extensions/signin/OWNERS#newcode2 chrome/browser/extensions/signin/OWNERS:2: guohui@chromium.org On 2017/03/10 22:06:33, Roger Tawa wrote: > Since ...
3 years, 9 months ago (2017-03-10 22:13:44 UTC) #3
Roger Tawa OOO till Jul 10th
Thanks! lgtm
3 years, 9 months ago (2017-03-10 22:20:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740953005/20001
3 years, 9 months ago (2017-03-10 22:21:31 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 22:35:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/094b5e38f83ceebb408911139f19...

Powered by Google App Engine
This is Rietveld 408576698