Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2740943002: Merged: Squashed multiple commits. (Closed)

Created:
3 years, 9 months ago by Igor Sheludko
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: [typedarrays] Fix Out of Bound Access in TypedArraySortFast Revision: cd3a76d56f544c5c90cd262d2576b7bb1ef04c13 Merged: [typedarrays] No callbacks for fast sorting of integer typed arrays Revision: a3709d47e65885ba1dbae086dd8452cbf3cbe899 Merged: [typedarrays] check byte offset for fast typedarray sort Revision: 5fc1bd5b32be6812c8e09d2486a81eb7d0918a1c BUG=chromium:696251, v8:5953, v8:5953 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2740943002 . Cr-Commit-Position: refs/branch-heads/5.8@{#19} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/6b8007f1ce746b87e76ade835bb1e4487dfde4e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -23 lines) Patch
M src/runtime/runtime-typedarray.cc View 2 chunks +30 lines, -23 lines 0 comments Download
M test/mjsunit/es6/typedarray-sort.js View 1 chunk +8 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-696251.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Igor Sheludko
3 years, 9 months ago (2017-03-09 08:04:55 UTC) #1
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-09 08:05:53 UTC) #2
Igor Sheludko
3 years, 9 months ago (2017-03-09 08:07:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b8007f1ce746b87e76ade835bb1e4487dfde4e3 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698