Replace png icons from CBD with vector graphics.

Replace png icons from CBD with vector graphics.

Screenshot with new vector icons (cache, passwords)
https://screenshot.googleplex.com/2CrUBWX3suU.png

Previous screenshot:
https://screenshot.googleplex.com/GQ0LeamyMkN.png

BUG=699711
Review-Url: https://codereview.chromium.org/2740893004
Cr-Commit-Position: refs/heads/master@{#456389}
Committed: https://chromium.googlesource.com/chromium/src/+/aaa07f46771138c6b4f554ee34dba359ebd68813

[dullweber, 2017-03-10 09:43:29]

dullweber@chromium.org changed reviewers:
+ twellington@chromium.org

[dullweber, 2017-03-10 09:43:29]

Hi, I got a bug report that I increased the binary size too much and I should
replace the png files I added recently with xml files. 
I had to add tools:targetApi="21" to each file to remove a lint warning but I am
not sure if this will work on phones that don't support this api level?

[dullweber, 2017-03-10 09:47:01]

Description was changed from

==========
Replace png icons from CBD with vector graphics.

BUG=699711
==========

to

==========
Replace png icons from CBD with vector graphics.

Screenshot with new vector icons (history, cache, passwords)
https://screenshot.googleplex.com/2CrUBWX3suU.png

Previous screenshot:
https://screenshot.googleplex.com/GQ0LeamyMkN.png

BUG=699711
==========

[Theresa, 2017-03-10 16:03:40]

On 2017/03/10 09:43:29, dullweber wrote:
> Hi, I got a bug report that I increased the binary size too much and I should
> replace the png files I added recently with xml files. 
> I had to add tools:targetApi="21" to each file to remove a lint warning but I
am
> not sure if this will work on phones that don't support this api level?

This will work on phones with older versions of library due to the support
library.

I'm using the ic_history_grey600_24dp PNGs in an in-flight CL
(https://codereview.chromium.org/2738843003/) -- can you please leave them for
now? I need to tint the history icon and we still haven't come up with a good
way to combine tinted drawables with vectors (although we're getting closer to a
solution -- see crbug.com/697888).

[dullweber, 2017-03-10 16:51:07]

On 2017/03/10 16:03:40, Theresa wrote:
> On 2017/03/10 09:43:29, dullweber wrote:
> > Hi, I got a bug report that I increased the binary size too much and I
should
> > replace the png files I added recently with xml files. 
> > I had to add tools:targetApi="21" to each file to remove a lint warning but
I
> am
> > not sure if this will work on phones that don't support this api level?
> 
> This will work on phones with older versions of library due to the support
> library.
> 
> I'm using the ic_history_grey600_24dp PNGs in an in-flight CL
> (https://codereview.chromium.org/2738843003/) -- can you please leave them for
> now? I need to tint the history icon and we still haven't come up with a good
> way to combine tinted drawables with vectors (although we're getting closer to
a
> solution -- see crbug.com/697888).

Thanks, I reverted the history icon to png.
Tinted vector drawables would be great, then I could also replace the
bookmark_edit icon.

[Theresa, 2017-03-10 16:56:37]

On 2017/03/10 16:51:07, dullweber wrote:
> On 2017/03/10 16:03:40, Theresa wrote:
> > On 2017/03/10 09:43:29, dullweber wrote:
> > > Hi, I got a bug report that I increased the binary size too much and I
> should
> > > replace the png files I added recently with xml files. 
> > > I had to add tools:targetApi="21" to each file to remove a lint warning
but
> I
> > am
> > > not sure if this will work on phones that don't support this api level?
> > 
> > This will work on phones with older versions of library due to the support
> > library.
> > 
> > I'm using the ic_history_grey600_24dp PNGs in an in-flight CL
> > (https://codereview.chromium.org/2738843003/) -- can you please leave them
for
> > now? I need to tint the history icon and we still haven't come up with a
good
> > way to combine tinted drawables with vectors (although we're getting closer
to
> a
> > solution -- see crbug.com/697888).
> 
> Thanks, I reverted the history icon to png.
> Tinted vector drawables would be great, then I could also replace the
> bookmark_edit icon.

Thanks!

For this to work on API < 21, I think you're going to have to use
VectorDrawableCompat#create():
https://cs.chromium.org/chromium/src/third_party/android_tools/sdk/sources/an...

There's an example in HistoryManager here:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

If someone in your office has a KitKat or Jellybean device to test on, this
would be a great patch to test out on an older device.

[dullweber, 2017-03-10 17:05:13]

On 2017/03/10 16:56:37, Theresa wrote:
> On 2017/03/10 16:51:07, dullweber wrote:
> > On 2017/03/10 16:03:40, Theresa wrote:
> > > On 2017/03/10 09:43:29, dullweber wrote:
> > > > Hi, I got a bug report that I increased the binary size too much and I
> > should
> > > > replace the png files I added recently with xml files. 
> > > > I had to add tools:targetApi="21" to each file to remove a lint warning
> but
> > I
> > > am
> > > > not sure if this will work on phones that don't support this api level?
> > > 
> > > This will work on phones with older versions of library due to the support
> > > library.
> > > 
> > > I'm using the ic_history_grey600_24dp PNGs in an in-flight CL
> > > (https://codereview.chromium.org/2738843003/) -- can you please leave them
> for
> > > now? I need to tint the history icon and we still haven't come up with a
> good
> > > way to combine tinted drawables with vectors (although we're getting
closer
> to
> > a
> > > solution -- see crbug.com/697888).
> > 
> > Thanks, I reverted the history icon to png.
> > Tinted vector drawables would be great, then I could also replace the
> > bookmark_edit icon.
> 
> Thanks!
> 
> For this to work on API < 21, I think you're going to have to use
> VectorDrawableCompat#create():
>
https://cs.chromium.org/chromium/src/third_party/android_tools/sdk/sources/an...
> 
> There's an example in HistoryManager here:
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
> 
> If someone in your office has a KitKat or Jellybean device to test on, this
> would be a great patch to test out on an older device.

Great, I found someone with a Nexus 5 on 4.4.4. I will test with it on monday.

[dullweber, 2017-03-13 13:04:29]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 13:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-03-13 13:05:34]

Description was changed from

==========
Replace png icons from CBD with vector graphics.

Screenshot with new vector icons (history, cache, passwords)
https://screenshot.googleplex.com/2CrUBWX3suU.png

Previous screenshot:
https://screenshot.googleplex.com/GQ0LeamyMkN.png

BUG=699711
==========

to

==========
Replace png icons from CBD with vector graphics.

Screenshot with new vector icons (cache, passwords)
https://screenshot.googleplex.com/2CrUBWX3suU.png

Previous screenshot:
https://screenshot.googleplex.com/GQ0LeamyMkN.png

BUG=699711
==========

[dullweber, 2017-03-13 13:06:40]

I added the compatibility fix and tested it on a kitkat device.

[commit-bot: I haz the power, 2017-03-13 13:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 13:42:53]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-03-13 15:44:23]

lgtm

[dullweber, 2017-03-13 15:48:35]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-03-13 15:49:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 15:53:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489420115837520,
"parent_rev": "5597947fdabe0d8449d99f9d43c041613a501b47", "commit_rev":
"aaa07f46771138c6b4f554ee34dba359ebd68813"}

[commit-bot: I haz the power, 2017-03-13 15:55:09]

Description was changed from

==========
Replace png icons from CBD with vector graphics.

Screenshot with new vector icons (cache, passwords)
https://screenshot.googleplex.com/2CrUBWX3suU.png

Previous screenshot:
https://screenshot.googleplex.com/GQ0LeamyMkN.png

BUG=699711
==========

to

==========
Replace png icons from CBD with vector graphics.

Screenshot with new vector icons (cache, passwords)
https://screenshot.googleplex.com/2CrUBWX3suU.png

Previous screenshot:
https://screenshot.googleplex.com/GQ0LeamyMkN.png

BUG=699711

Review-Url: https://codereview.chromium.org/2740893004
Cr-Commit-Position: refs/heads/master@{#456389}
Committed:
https://chromium.googlesource.com/chromium/src/+/aaa07f46771138c6b4f554ee34db...
==========

[commit-bot: I haz the power, 2017-03-13 15:55:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aaa07f46771138c6b4f554ee34db...