Simplify directional selection check in FrameSelection::moveCaretSelection()

Simplify directional selection check in FrameSelection::moveCaretSelection()

This patch replaces
 FrameSeleciton::computeVisibleSelectionInDOMTree().isDirectional()
to
 FrameSeleciton::selectionInDOMTree().isDirectional()
since visible position normalization does not affect selection directional,
to simplify source code for improving code health.

BUG=698633
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2740893003
Cr-Commit-Position: refs/heads/master@{#456020}
Committed: https://chromium.googlesource.com/chromium/src/+/33aee2483346831a1881aeedc837cb5bc6cbe97c

[yosin_UTC9, 2017-03-10 01:10:02]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 01:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-10 01:12:25]

Description was changed from

==========
2017-03-10T10:07:02

2017-03-10T10:06:17

BUG=698633
==========

to

==========
Simplify directional selection check in FrameSelection::moveCaretSelection()

This patch replaces
 FrameSeleciton::computeVisibleSelectionInDOMTree().isDirectional()
to
 FrameSeleciton::selectionInDOMTree().isDirectional()
since visible position normalization does not affect selection directional,
to simplify source code for improving code health.

BUG=698633
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-03-10 02:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:39:16]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-10 03:39:03]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-10 03:39:04]

PTAL

[tkent, 2017-03-10 07:54:30]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-10 07:54:30]

lgtm

[commit-bot: I haz the power, 2017-03-10 07:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 07:58:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489132470072600, "parent_rev":
"a1a19dd21fddaac8e934bd06f0067b8241ea7afc", "commit_rev":
"33aee2483346831a1881aeedc837cb5bc6cbe97c"}

[commit-bot: I haz the power, 2017-03-10 07:59:38]

Description was changed from

==========
Simplify directional selection check in FrameSelection::moveCaretSelection()

This patch replaces
 FrameSeleciton::computeVisibleSelectionInDOMTree().isDirectional()
to
 FrameSeleciton::selectionInDOMTree().isDirectional()
since visible position normalization does not affect selection directional,
to simplify source code for improving code health.

BUG=698633
TEST=n/a; no behavior changes
==========

to

==========
Simplify directional selection check in FrameSelection::moveCaretSelection()

This patch replaces
 FrameSeleciton::computeVisibleSelectionInDOMTree().isDirectional()
to
 FrameSeleciton::selectionInDOMTree().isDirectional()
since visible position normalization does not affect selection directional,
to simplify source code for improving code health.

BUG=698633
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2740893003
Cr-Commit-Position: refs/heads/master@{#456020}
Committed:
https://chromium.googlesource.com/chromium/src/+/33aee2483346831a1881aeedc837...
==========

[commit-bot: I haz the power, 2017-03-10 07:59:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33aee2483346831a1881aeedc837...

[RE66, 2017-03-10 11:19:58]

On 2017/03/10 07:59:40, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/33aee2483346831a1881aeedc837...

It has no code simplification benefits and it might risky assumption 
that "visible position normalization does not affect selection directional" m it
may change in feature

Over engineering

[Xiaocheng, 2017-03-10 19:01:39]

On 2017/03/10 at 11:19:58, RonEfrati wrote:
> On 2017/03/10 07:59:40, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
https://chromium.googlesource.com/chromium/src/+/33aee2483346831a1881aeedc837...
> 
> It has no code simplification benefits and it might risky assumption 
> that "visible position normalization does not affect selection directional" m
it may change in feature
> 
> Over engineering

If you think this patch breaks anything, please file a bug at crbug.com with a
concrete example of what it breaks.