Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2740893002: Settings reset prompt: Enable the feature for fieldtrial testing. (Closed)

Created:
3 years, 9 months ago by alito
Modified:
3 years, 9 months ago
Reviewers:
alito2, csharp, jwd
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings reset prompt: Enable the feature for fieldtrial testing. BUG= Review-Url: https://codereview.chromium.org/2740893002 Cr-Commit-Position: refs/heads/master@{#455796} Committed: https://chromium.googlesource.com/chromium/src/+/7fae73cb6d6bef3c2c8246c867961ed33e4eed57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.h View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
alito
PTAL.
3 years, 9 months ago (2017-03-09 04:55:44 UTC) #6
jwd
lgtm
3 years, 9 months ago (2017-03-09 15:17:39 UTC) #7
csharp
lgtm
3 years, 9 months ago (2017-03-09 17:48:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740893002/1
3 years, 9 months ago (2017-03-09 17:49:09 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:24:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fae73cb6d6bef3c2c8246c86796...

Powered by Google App Engine
This is Rietveld 408576698